Align custom traffic action with osc #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspar-ai
added
Bug
Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
caspar-ai
force-pushed
the
feature/align-custom-traffic-action-with-osc
branch
from
2fbd5ba to
e3452d3
Compare
caspar-ai
added
the
ReadyForCCBReview
clemenshabedank
approved these changes
Jun 9, 2021
kmeids
reviewed
Jun 9, 2021
osi_trafficcommand.proto
Outdated
Comment on lines
490
to
496
| // The custom command given to the traffic participant. | ||
| // | ||
| optional string command = 2; | ||
|
|
||
| // The type of the custom command given to the traffic participant. | ||
| // | ||
| optional string command_type = 3; |
There was a problem hiding this comment.
Output CCB 09.06.2021:
- Please provide more documentation on the "command" and "command_type" messages, stating the difference between them and how/in which situations should it be used.
- As a "note", please mention for both commands that they are mapped to OSC.
There was a problem hiding this comment.
Thanks @kmeids I have updated the comments as suggested.
Does that look OK to you?
kmeids
removed
the
ReadyForCCBReview
Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
caspar-ai
added
the
ReadyForCCBReview
|
@kmeids any update from the CCB group about whether this can be merged? |
|
CCB Output 21.07.2021
|
kmeids
added
Documentation
max-rosin
reviewed
Aug 4, 2021
max-rosin
reviewed
Aug 4, 2021
Co-authored-by: max-rosin <62103539+max-rosin@users.noreply.github.com> Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
caspar-ai
force-pushed
the
feature/align-custom-traffic-action-with-osc
branch
from
a4edb29 to
6aaadca
Compare
|
@max-rosin I agreed with your comment suggests and have applied those changes. Is there anything else to do on the documentation side? @pmai if not, I think over to you to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference to a related issue in the repository
Closes #522
Add a description
Add a second string field to the custom action to mirror that in the OSC definitions.
In line with standard OSI the field is optional so this is not a breaking change.
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board: