Skip to content

Extension of the Identifier message with an additional type #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

DerBaertige
Copy link
Contributor

@DerBaertige DerBaertige commented Jan 25, 2021

Description

The extension of the "message Identifier" allows the distinction between different types of the identifier value. Currently, during run-time, there is no possibility to represent a Identifier (which must be global unique) or a reference to a previous defined object.

Additionally, during discussed in the Harmonization Group, about Issue #156 that there should be a possibility to define identifiers, which are not set. In addition, the desire arose, that in LanePairing always both IDs should be initialized, which is solved with the new type value TYPE_UNKNOWN.

The usage MAX(uint64) is no longer required in the future, since it is mapped by the types TYPE_UNKNOWN and TYPE_ERROR. For reasons of backwards compatibility, it can be additionally set at TYPE_UNKNOWN oder TYPE_ERROR.

The Sensor specific tracking IDs, which are used by external sensor models, can be mapped by the "message ExternalIdentifier", Pull Request #465 and are more flexible for fulfilling the individual sensor specifications.

Check the checklist

  • My code and comments follow the style guidelines and contributors guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / travis ci pass locally with my changes.

…efinition

Signed-off-by: Georg Seifert <Georg.Seifert@carissma.eu>
@DerBaertige DerBaertige added FeatureRequest Proposals which enhance the interface or add additional features. Harmonisation The Group in the ASAM development project working on harmonisation with other standards. labels Jan 25, 2021
Signed-off-by: Georg Seifert <Georg.Seifert@carissma.eu>
@yash-shah-asam
Copy link
Member

Due to a lack of interest in the topic, we will close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FeatureRequest Proposals which enhance the interface or add additional features. Harmonisation The Group in the ASAM development project working on harmonisation with other standards.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants