Skip to content

ISO23150 compliance: Adding day of the month to [Traffic-Sign-Value-Unit] #635

Closed
@FlorianMueller87

Description

@FlorianMueller87

Describe the feature

ASAM OSI and ISO 23150 or AUTOSAR ADI have a common history. Unfortunately, the inner structure, the naming and the definitions of the standards are differentiated from each other. This makes the work of developers unnecessary complicated for mostly no technical reasons. All sides should strive to reduce inequality.

osi_trafficsign.proto message TrafficSignValue { enum Unit } need an entry which describes the day of the month.

Furthermore, the type need a entry kHour which describe the hour of the day.

Describe the solution you would like

Add a new entry named UNIT_DAY_OF_MONTH with the value 15 into osi_trafficsign.proto maessage TrafficSignValue { enum Unit }
As described in ISO231050:2021 A.2.67 Sign value unit:
The unit for the sign value is the day of the month.
the UNIT_DAY_OF_MONTH would be defined in the same way.

Add a new entry named UNIT_HOUR with the value 16 into osi_trafficsign.proto maessage TrafficSignValue { enum Unit }.

Describe alternatives you have considered

// Day of the week.
// Days since Monday. Monday = 0; Tuesday = 1; ...
//
UNIT_WEEKDAY = 13;

// Day of the month.
//
UNIT_DAY = 15;

Describe the backwards compatibility

An element would be added, no name would be changed, and no element would be shifted. Due to no backwards compatibility should occur.
Compatibilityof the alternative:
The entry with the value would have the same definition as in older version. However, the entry name is different to older versions. This is the more consistent solution regarding to the naming of this type. Compiler would detect this change.

Adding UNIT_HOUR will not lead to backwards compability problems.

Additional context

ISO23150:2021A.2.67 Sign value unit:

SignValueUnit_Day | The unit for the sign value is the day of the month.

_ @SignValueUnit_Weekday_ | The unit for the sign value is the weekday.
The numeric value of the weekday is defined as:
- Sunday (Sign value (A.2.66) := 0)
- …
- Saturday (Sign value (A.2.66) := 6)

@ThomasNaderBMW @jdsika @schmidtlorenz

Metadata

Metadata

Assignees

Labels

HarmonisationThe Group in the ASAM development project working on harmonisation with other standards.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions