Skip to content

introducing OSW-Express #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Oct 5, 2024
Merged

introducing OSW-Express #66

merged 22 commits into from
Oct 5, 2024

Conversation

@LukasGold
Copy link
Contributor

Includes:

  • osw.express.OswExpress introduces various comfort functions.
  • Integration tests for these new functions
  • Almost all examples have been reworked to incorporate the new OswExpress, which offers a significant reduction in required code lines

LukasGold and others added 17 commits September 13, 2024 09:48
@LukasGold @MatPoppFHG
Introduction of osw.express - convenience functions for osw-python
f14e7f1 
With accompanying additions to auth.py

Based on a discussion with @MatPoppFHG

Co-authored-by: Lukas Gold <lukas.gold@isc.fraunhofer.de>
Co-authored-by: Matthias Albert Popp <matthias.albert.popp@isc.fraunhofer.de>
@LukasGold @MatPoppFHG
Review with @MatPoppFHG
b58cd0f 
* Reworking express.py and accompanying changes of auth.py
* additional (minimal) examples using osw.express

Co-authored-by: Lukas Gold <lukas.gold@isc.fraunhofer.de>
Co-authored-by: Matthias Albert Popp <matthias.albert.popp@isc.fraunhofer.de>
@LukasGold
typo fixed
86bbe62
@LukasGold
Implementing context manager compatible osw_download_file
16f35c6
@LukasGold
small simplification
217fc45
@LukasGold
Using serial copy page by default to avoid mishaps
2b3b4db
@LukasGold
Adding hints on optional arguments
411e6d2
@LukasGold
Removed deleted function osw_open from the example
e66c2aa
@LukasGold
changes default behavior to persist credentials + treating all cases,…
50cf8a6 
… incl. cred_filepath being a list
@LukasGold
fix: typo
634364b
@LukasGold
changes accompanying changes to osw.auth
2775fd6
@LukasGold
hot fix on auth.py
3d26937
@LukasGold
fixing typos, missing variable definitions, adding comments
e6cfb3f
@LukasGold
extending OSW-Express and associated integration tests
f85e129
@LukasGold
incorporating feedback from the team on OswExpress
8a0f171
@LukasGold
Adaptation of examples to the newly introduced OswExpress
edca046
@LukasGold
Adding in-memory controller + some minor improvements
c3fca9f
@LukasGold LukasGold added the enhancement New feature or request label Sep 28, 2024
@LukasGold LukasGold self-assigned this Sep 28, 2024
@LukasGold LukasGold linked an issue Sep 28, 2024 that may be closed by this pull request
enh: Convenience wrapper for file download/upload #50
Closed
@coveralls
Copy link

coveralls commented Sep 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11195540311

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 335 of 432 (77.55%) changed or added relevant lines in 10 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+2.4%) to 45.823%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/osw/controller/file/s3.py 0 2 0.0%
src/osw/auth.py 71 87 81.61%
src/osw/controller/file/memory.py 0 17 0.0%
src/osw/express.py 232 294 78.91%
Files with Coverage Reduction New Missed Lines %
src/osw/auth.py 1 81.54%
Totals Coverage Status
Change from base Build 10862354643: 2.4%
Covered Lines: 2571
Relevant Lines: 4562
💛 - Coveralls

@LukasGold LukasGold marked this pull request as ready for review September 30, 2024 07:21
simontaurus
simontaurus reviewed Oct 4, 2024
View reviewed changes
Copy link
Contributor

@simontaurus simontaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions (not strictly required for merge)

@simontaurus simontaurus mentioned this pull request Oct 5, 2024
Closed
@simontaurus
refactor: update examples
8ef5949 
remove outdated code/example
@simontaurus simontaurus mentioned this pull request Oct 5, 2024
Open
@simontaurus simontaurus mentioned this pull request Oct 5, 2024
Closed
@simontaurus simontaurus merged commit a76f0ea into main Oct 5, 2024
9 checks passed
@LukasGold LukasGold linked an issue Nov 26, 2024 that may be closed by this pull request
download / upload of files via osw.express functions should maintain filename #94
Open
@LukasGold LukasGold removed a link to an issue Nov 26, 2024
download / upload of files via osw.express functions should maintain filename #94
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simontaurus simontaurus simontaurus left review comments

@SimonStier SimonStier Awaiting requested review from SimonStier

Assignees

@LukasGold LukasGold

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

enh: Convenience wrapper for file download/upload

4 participants

@LukasGold @coveralls @simontaurus