Skip to content

Conversation

@MayamaTakeshi
Copy link
Contributor

Hello,
here is my attempt to correct these two issues:
#32
registrar:save is ignoring min_expires, max_expires from cfg
#25
tm:t_forward_nonack relay message before starting retrans and fr timers.

regards,
Takeshi

mod tm: forcing retrans and fr timers to be started before request is relayed
@bogdan-iancu
Copy link
Member

Hi Takeshi,

I manually uploaded the patch on the REGISTRAR module - thank you.

In regards to the patch on TM, I do not really agree with it - the timer has to start AFTER the INVITE was sent out. IF you start it before and have a delay in sending the INVITE (maybe long TCP setup), the first re-transmission may be fire in the same time with the original INVITE - we had this problem before.

I will close this request and let's continue the discussion on #25.

Thanks and regards,
Bogdan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants