Module registrar parameter min_expires has no effect

[MayamaTakeshi]

Hello,
sorry if this gets double-posted (I thought I added this issue yesterday, but since i don't see it now, I am posting it again as maybe i forgot to submit it).

Latest version (head) of module registrar is ignoring param min_expires (and probably max_expires too).

I checked the code and it seems to me function save_aux (in save.c) failed to initialize sctx.
I tested changing with these lines and it worked:

--- modules/registrar/save.c (revision 10142)
+++ modules/registrar/save.c (working copy)
@@ -749,6 +749,9 @@
sctx.max_contacts = -1;

    sctx.flags = 0;

•   sctx.min_expires = min_expires;
  

•   sctx.max_expires = max_expires;
  

  • if ( _f ) {
    if (fixup_get_svalue( _m, (gparam_p)_f, &flags_s)!=0) {
    LM_ERR("invalid flags parameter");

This is the version I tested:

svn log |head

---

r10142 | opensipsrelease | 2013-08-03 00:41:23 +0900 (Sat, 03 Aug 2013) | 10 lines

Improved PUA DialogInfo.

Several fixes here:

• Dialog callbacks are now correctly setup after a restart of
  OpenSIPS. In other words, restarting OpenSIPS will not lead to ghost BLFs
  anymore.
• Added an option allowing not to publish state change in case of reINVITE.

Regards,
Takeshi

[bogdan-iancu]

Hi Takeshi,

Thanks for the fix - indeed, there is a bug there ; I will upload the fix via the pull request you created.

Regards,
Bogdan