Move to manylinux_2_28_x86_64 (#496)

OpenMined · Oct 3, 2024 · 2c9cc34 · 2c9cc34 · github-actions · Oct 3, 2024
1 parent 264b71f
commit 2c9cc34
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 41 deletions.
diff --git a/.github/workflows/pythonpublish-linux.yml b/.github/workflows/pythonpublish-linux.yml
@@ -17,13 +17,7 @@ jobs:
           - cp312-cp312
 
     runs-on: ubuntu-latest
-    container: quay.io/pypa/manylinux2014_x86_64
-
-    # node20 can't run on manylinux2014 as it requires newer version of GLIBC
-    # https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
-    env:
-      ACTIONS_RUNNER_FORCE_ACTIONS_NODE_VERSION: node16
-      ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
+    container: quay.io/pypa/manylinux_2_28_x86_64
 
     steps:
       - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
@@ -33,9 +27,9 @@ jobs:
         run: |
             echo "/opt/python/${{ matrix.python-version }}/bin" >> $GITHUB_PATH
       - name: Install dependencies
-        run: .github/workflows/scripts/install_req_centos.sh
+        run: .github/workflows/scripts/install_req_manylinux.sh
       - name: Build and publish
         env:
           TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }}
           TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }}
-        run: .github/workflows/scripts/release_centos.sh
+        run: .github/workflows/scripts/release_manylinux.sh
diff --git a/.github/workflows/scripts/install_req_centos.sh b/.github/workflows/scripts/install_req_centos.sh
diff --git a/.github/workflows/scripts/install_req_manylinux.sh b/.github/workflows/scripts/install_req_manylinux.sh
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+# install python dependencies
+python3 -m pip install --upgrade pip
+python3 -m pip install setuptools wheel twine auditwheel
diff --git a/.github/workflows/scripts/release_centos.sh b/.github/workflows/scripts/release_centos.sh
diff --git a/.github/workflows/scripts/release_manylinux.sh b/.github/workflows/scripts/release_manylinux.sh
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+python3 -m pip wheel . -w dist/ --no-deps
+auditwheel repair dist/*.whl --plat $AUDITWHEEL_PLAT
+twine upload --skip-existing wheelhouse/*
Benchmark suite	Current: `2c9cc34`	Previous: `264b71f`	Ratio
`tests/python/benchmarks/test_ops.py::test_perf_bfv[256-bfv_test-add]`	`3358.5560895702897` iter/sec (`stddev: 0.000001645522078482284`)	`8643.950824555428` iter/sec (`stddev: 0.000003551626309436832`)	`2.57`
`tests/python/benchmarks/test_ops.py::test_perf_bfv[4096-bfv_test-add]`	`3352.1514174863937` iter/sec (`stddev: 0.0000014623501715163625`)	`8698.915401837972` iter/sec (`stddev: 0.0000014620686432503777`)	`2.60`