Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes undefined variable, closes #712 #729

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Fixes undefined variable, closes #712 #729

merged 1 commit into from
Apr 24, 2020

Conversation

sreichel
Copy link
Contributor

Ref #712

@sreichel sreichel added the bug label Jun 16, 2019
kkrieger85
kkrieger85 approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@kkrieger85 kkrieger85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$shippinngAddress will be set in line 706.

So this change looks good and reasonable

@tmotyl tmotyl merged commit bb15ebd into OpenMage:1.9.4.x Apr 24, 2020
@sreichel sreichel deleted the hotfix/undefined-var-1 branch June 19, 2020 20:03
@sreichel sreichel added the Component: Customer Relates to Mage_Customer label Jun 19, 2020
@sreichel sreichel added this to the Release 19.4.2 milestone Jun 27, 2020
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 20, 2020
@sreichel @edannenberg
[bug-OpenMage#729] Var typo in Mage_Customer_Model_Convert_Parser_Cus…
69df9eb 
…tomer::parse()

$shippingAddress is not defined
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 24, 2020
@sreichel @edannenberg
[bug-OpenMage#729] Var typo in Mage_Customer_Model_Convert_Parser_Cus…
6b4b882 
…tomer::parse()

$shippingAddress is not defined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinmollenhour colinmollenhour colinmollenhour approved these changes

@tmotyl tmotyl tmotyl approved these changes

@OZZlE OZZlE OZZlE approved these changes

@kkrieger85 kkrieger85 kkrieger85 approved these changes

Assignees
No one assigned
Labels
bug Component: Customer Relates to Mage_Customer
Projects
None yet
Milestone
Release 19.4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@sreichel @colinmollenhour @tmotyl @OZZlE @kkrieger85