Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Mage_Customer_Model_Convert_Parser_Customer::parse() #712

Closed
sreichel opened this issue Jun 8, 2019 · 0 comments
Closed

[Bug] Mage_Customer_Model_Convert_Parser_Customer::parse() #712

sreichel opened this issue Jun 8, 2019 · 0 comments
Labels
bug Component: Customer Relates to Mage_Customer

Comments

@sreichel
Copy link
Contributor

sreichel commented Jun 8, 2019

Untested ... be should lead to fatal error "call save() on undefinded" ...

                    if (!$model->getDefaultBilling()) {
                        $billingAddress->setCustomerId($model->getId());
                        $billingAddress->setIsDefaultBilling(true);
                        $billingAddress->save();
                        $model->setDefaultBilling($billingAddress->getId());
                        $model->addAddress($billingAddress);
                        if ($customer->getDefaultBilling()) {
                            $model->setDefaultBilling($customer->getDefaultBilling());
                        } else {
                            $shippingAddress->save(); # <- should be $billingAddress
                            $model->setDefaultShipping($billingAddress->getId());
                            $model->addAddress($billingAddress);
                        }
                    }
@sreichel sreichel added bug good first issue easy to solve issues labels Jun 13, 2019
sreichel added a commit that referenced this issue Jun 15, 2019
@tmotyl tmotyl closed this as completed in bb15ebd Apr 24, 2020
@sreichel sreichel added fixed Component: Customer Relates to Mage_Customer and removed good first issue easy to solve issues labels Jun 19, 2020
@sreichel sreichel added this to the Release 19.4.2 milestone Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Component: Customer Relates to Mage_Customer
Projects
None yet
Development

No branches or pull requests

1 participant