Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix admin grid filter, ref #1430 #2602

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Fix admin grid filter, ref #1430 #2602

merged 2 commits into from
Sep 14, 2022

Conversation

sreichel
Copy link
Contributor

Description (*)

...

Fixed Issues (if relevant)

  1. Fixes OpenMage/magento-lts#1430#issuecomment-1246193830
  2. Fixes Some fixes for phpdocs #2588 (comments)
  3. Closes Revert "Strip null bytes from strings and filter conditions." #2600

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: PayPal Relates to Mage_Paypal labels Sep 14, 2022
@sreichel sreichel mentioned this pull request Sep 14, 2022
Merged
4 tasks
@fballiano fballiano merged commit 8604a6d into OpenMage:1.9.4.x Sep 14, 2022
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 8604a6d. ± Comparison against base commit bbe1184.

@sreichel sreichel deleted the hotfix/1430 branch September 14, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano approved these changes

@ADDISON74 ADDISON74 ADDISON74 approved these changes

Assignees
No one assigned
Labels
Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: PayPal Relates to Mage_Paypal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @fballiano @ADDISON74