Revert "Strip null bytes from strings and filter conditions." #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9a49aa1.
github-actions
bot
added
Component: Core
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
Just faced this issue today too. |
elidrissidev
approved these changes
Sep 14, 2022
ADDISON74
approved these changes
Sep 14, 2022
kiatng
approved these changes
Sep 14, 2022
|
Has someone time to test this: #1430 (comment) If not lets merge an reapply @colinmollenhour fixed PR again. |
3 tasks
|
I think it was better to merge this revert in the Git history. Later a new PR could be created to come up with the fix to the initial PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1430 due to #1430 (comment)