Outdated: DMXControl3 Import #75
Conversation
| const info = device.information[0]; | ||
| const manName = info.vendor[0]; | ||
| const manKey = manName.toLowerCase().replace(/[^a-z0-9\-]+/g, '-'); | ||
| out.manufacturers[manKey] = { |
There was a problem hiding this comment.
What if the manufacturer does already exist?
There was a problem hiding this comment.
Does an import plugin have to care about existing data? The ecue plugin doesn't check for existing manufacturers either.
There was a problem hiding this comment.
True. Then leave it without a check, we can always manually correct mistakes in the pull request.
Added script to test importing the whole DMXControl library
(and ordered them alphabetically)
…rary into dmxcontrol3
|
The (German) documentation of the DMXC3 format has been heavily improved since the last commits in this branch. It better explains how DMXControl uses switching channels for specific functions like Strobe type and gives a detailed explanation of allowed values and how the functions work. Additionally, it states new interesting facts like the support for up to 32bit channels ("fine", "ultra", "ultrafine" – pretty describing names!). It's very good that we have an official documentation for this and don't need to do reverse engineering, but it also makes clear that this plugin isn't that easy and we probably have to update our fixture format several times. |
fxedel
added
the
wontfix
|
This PR is quite old – updating it would require a lot of work and we want to rework importing anyway. Also, importing isn't supported in the UI yet, so the benefit of refactoring this PR is relatively low (at the moment). I'll start with the export in another PR, but keep this PR as reference on DMXControl's fixture format. |
work on #66