Skip to content

Cuda registration #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
3b86289
Moved cuda registration to its own files, still looking for a way to …
blackzafiro Mar 2, 2017
7111eec
Will need thrust to create 3D clouds, so -fno-exceptions will be remo…
blackzafiro Apr 4, 2017
a4453bf
Began implementation of CudaRegistration.
Mar 8, 2017
2199537
Added frame for cuda device data. Began implementing apply.
blackzafiro Mar 21, 2017
46fd5ab
Added diretory 'compile' to .gitignore.
blackzafiro Apr 4, 2017
ba92c41
Removed Eclipse auxiliary files
blackzafiro Apr 4, 2017
9133eeb
Merge branch 'OpenKinect:master' into CudaRegistration
blackzafiro Mar 22, 2024
601df00
Fixed spaces vs tab convention
veroarriola Aug 23, 2024
0de07f9
Removed OpenGL warning
veroarriola Aug 23, 2024
e1e73cf
Changing to CUDA as language, not complete.
veroarriola Aug 26, 2024
d279a60
Updated to ENABLE_LANGUAGE(CUDA). Old code is still there but commented.
veroarriola Aug 27, 2024
3d23d10
Fussing as it should have been from the beginning.
veroarriola Sep 4, 2024
4a71a37
Main
veroarriola Sep 6, 2024
8f23ded
Sequence diagram for dev, start.
veroarriola Sep 9, 2024
6bef13a
Sequence diagram with frame production in Protonect complete.
veroarriola Jan 30, 2025
828cfa0
Testing cuda_registration in Protonect. Need to debug.
veroarriola Jan 30, 2025
d634183
Debugging lines...
veroarriola Jan 30, 2025
9e70e6f
Debugging...
veroarriola Jan 31, 2025
29e2b6e
Bug gone. I had dst and src inverted in cudadMemcpyAsync.
veroarriola Feb 5, 2025
53c6156
Set CMKAE_CUDA_ARCHITECTURES
veroarriola Feb 13, 2025
885b9df
CUDA 50 for our laptop.
veroarriola Mar 13, 2025
0ab3569
Arquitectura para 2a laptop
veroarriola Mar 13, 2025
6b78902
RgbPacketProcessor creation
veroarriola Mar 19, 2025
b1a66ec
Build instructions for development.
veroarriola Mar 26, 2025
e93b15e
Corrected error in directories.
veroarriola Mar 26, 2025
4a785b2
Indications to avoid VAAPI
veroarriola Apr 1, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
build
compile

# Dependency folders
depends/*/
Expand Down Expand Up @@ -123,6 +124,11 @@ ClientBin/
*.pfx
*.publishsettings

# Nsight Nvidia Eclipse
.cproject
.project
.settings/

# RIA/Silverlight projects
Generated_Code/

Expand Down
10 changes: 9 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ SET(SOURCES
include/libfreenect2/packet_pipeline.h
include/internal/libfreenect2/packet_processor.h
include/libfreenect2/registration.h
include/libfreenect2/cuda_registration.h
Copy link
Member

@xlz xlz Apr 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API specific implementation class should be put in registration.h, not cuda_registration.h. See how CUDA depth processor doesn't have its own header instead its definition is in depth_packet_processor.h.

Here was the API design I outlined #744 (comment)

But actually, don't worry about this at this moment.

include/internal/libfreenect2/resource.h
include/internal/libfreenect2/rgb_packet_processor.h
include/internal/libfreenect2/rgb_packet_stream_parser.h
Expand Down Expand Up @@ -354,17 +355,24 @@ IF(ENABLE_CUDA)
)
SET(CUDA_FLAGS -use_fast_math)
IF(NOT MSVC)
SET(CUDA_FLAGS "${CUDA_FLAGS} -Xcompiler -fPIC")
SET(CUDA_FLAGS "${CUDA_FLAGS} -Xcompiler -fPIC -D_FORCE_INLINES")
ENDIF()
IF(HAVE_CXX11 EQUAL yes AND CUDA_VERSION VERSION_GREATER 7.0)
SET(CUDA_FLAGS "${CUDA_FLAGS} -std=c++11")
ENDIF()

SET(OLD_CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
STRING(REGEX REPLACE "-std=c\\+\\+.." "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
# Thrust requires exceptions. If OpenCL from NVidia is used we don't need this flag.
STRING(REGEX REPLACE "-fno-exceptions" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
MESSAGE(STATUS "*************")
mESSAGE(STATUS ${CMAKE_CXX_FLAGS})
MESSAGE(STATUS ${CUDA_FLAGS})
MESSAGE(STATUS "*************")
CUDA_COMPILE(CUDA_OBJECTS
src/cuda_depth_packet_processor.cu
src/cuda_kde_depth_packet_processor.cu
src/cuda_registration.cu
OPTIONS ${CUDA_FLAGS}
)
SET(CMAKE_CXX_FLAGS "${OLD_CMAKE_CXX_FLAGS}")
Expand Down
162 changes: 162 additions & 0 deletions include/libfreenect2/cuda_registration.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,162 @@
/*
* This file is part of the OpenKinect Project. http://www.openkinect.org
*
* Copyright (c) 2014 individual OpenKinect contributors. See the CONTRIB file
* for details.
*
* This code is licensed to you under the terms of the Apache License, version
* 2.0, or, at your option, the terms of the GNU General Public License,
* version 2.0. See the APACHE20 and GPL2 files for the text of the licenses,
* or the following URLs:
* http://www.apache.org/licenses/LICENSE-2.0
* http://www.gnu.org/licenses/gpl-2.0.txt
*
* If you redistribute this file in source form, modified or unmodified, you
* may:
* 1) Leave this header intact and distribute it under the same terms,
* accompanying it with the APACHE20 and GPL20 files, or
* 2) Delete the Apache 2.0 clause and accompany it with the GPL2 file, or
* 3) Delete the GPL v2 clause and accompany it with the APACHE20 file
* In all cases you must keep the copyright notice intact and include a copy
* of the CONTRIB file.
*
* Binary distributions must follow the binary distribution requirements of
* either License.
*/

/** @file cuda_registration.h Class for merging depth and color frames using cuda. */

#ifndef CUDA_REGISTRATION_H_
#define CUDA_REGISTRATION_H_

#include <string>
#include <libfreenect2/config.h>
#include <libfreenect2/libfreenect2.hpp>
#include <libfreenect2/frame_listener.hpp>

#ifdef LIBFREENECT2_WITH_CUDA_SUPPORT
#include <thrust/host_vector.h>
#include <thrust/device_vector.h>
#include <thrust/copy.h>
#include <thrust/device_ptr.h>
#include <thrust/sequence.h>

namespace libfreenect2
{

typedef thrust::tuple<float, float, float, float> TupleXYZRGB;

/**
* Frame whose data is allocated on device.
*/
class LIBFREENECT2_API CudaDeviceFrame: public Frame
{
public:
/** Construct a new frame.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should fix your indentation. This project uses 2 spaces. It's hard to look at code that switches between indentation styles.

* @param width Width in pixel
* @param height Height in pixel
* @param bytes_per_pixel Bytes per pixel
*/
CudaDeviceFrame(size_t width, size_t height, size_t bytes_per_pixel);
virtual ~CudaDeviceFrame();
private:
bool allocateMemory();
};

class CudaRegistrationImpl;

/** @defgroup registration Registration and Geometry
* Register depth to color, create point clouds. */

/** Combine frames of depth and color camera using gpus. @ingroup registration
* Right now this class uses a reverse engineered formula that uses factory
* preset extrinsic parameters the same way the Registration class does.
*/
class LIBFREENECT2_API CudaRegistration
{
public:
/**
* @param depth_p Depth camera parameters. You can use the factory values, or use your own.
* @param rgb_p Color camera parameters. Probably use the factory values for now.
*/
CudaRegistration(Freenect2Device::IrCameraParams depth_p, Freenect2Device::ColorCameraParams rgb_p);
~CudaRegistration();

/** Undistort and register a single depth point to color camera.
* @param dx Distorted depth coordinate x (pixel)
* @param dy Distorted depth coordinate y (pixel)
* @param dz Depth value (millimeter)
* @param[out] cx Undistorted color coordinate x (normalized)
* @param[out] cy Undistorted color coordinate y (normalized)
*/
void apply(int dx, int dy, float dz, float& cx, float &cy) const;

/** Map color images onto depth images
* @param rgb Color image (1920x1080 BGRX)
* @param depth Depth image (512x424 float)
* @param[out] undistorted Undistorted depth image
* @param[out] registered Color image for the depth image (512x424)
* @param enable_filter Filter out pixels not visible to both cameras.
* @param[out] bigdepth If not `NULL`, return mapping of depth onto colors (1920x1082 float). **1082** not 1080, with a blank top and bottom row.
* @param[out] color_depth_map Index of mapped color pixel for each depth pixel (512x424).
*/
bool apply(const Frame* rgb, const Frame* depth, CudaDeviceFrame* undistorted, CudaDeviceFrame* registered, const bool enable_filter = true, CudaDeviceFrame* bigdepth = 0, int* color_depth_map = 0) const;

/** Undistort depth
* @param depth Depth image (512x424 float)
* @param[out] undistorted Undistorted depth image
*/
void undistortDepth(const Frame* depth, Frame* undistorted) const;

/** Construct a 3-D point with color in a point cloud.
* @param undistorted Undistorted depth frame from apply().
* @param registered Registered color frame from apply().
* @param r Row (y) index in depth image.
* @param c Column (x) index in depth image.
* @param[out] x X coordinate of the 3-D point (meter).
* @param[out] y Y coordinate of the 3-D point (meter).
* @param[out] z Z coordinate of the 3-D point (meter).
* @param[out] rgb Color of the 3-D point (BGRX). To unpack the data, use
*
* const uint8_t *p = reinterpret_cast<uint8_t*>(&rgb);
* uint8_t b = p[0];
* uint8_t g = p[1];
* uint8_t r = p[2];
*/
void getPointXYZRGB (const Frame* undistorted, const Frame* registered, int r, int c, float& x, float& y, float& z, float& rgb) const;

/** Construct a 3-D point in a point cloud.
* @param undistorted Undistorted depth frame from apply().
* @param r Row (y) index in depth image.
* @param c Column (x) index in depth image.
* @param[out] x X coordinate of the 3-D point (meter).
* @param[out] y Y coordinate of the 3-D point (meter).
* @param[out] z Z coordinate of the 3-D point (meter).
*/
void getPointXYZ (const Frame* undistorted, int r, int c, float& x, float& y, float& z) const;

/**
* Construct a point cloud as thrust vector of XYZRGB data as tuples of <float, float, float, float> in device memory, which can be used
* for further processing with CUDA.
* @param undistorted Undistorted depth frame from apply().
* @param registered Registered color frame from apply().
* @param[out] cloud_data <X, Y, Z, RGB> coordinates of the 3-D point (meter) and color (BGRX).
* To unpack the color data, use
* const uint8_t *p = reinterpret_cast<uint8_t*>(&rgb);
* uint8_t b = p[0];
* uint8_t g = p[1];
* uint8_t r = p[2];
*/
void getPointXYZRGB(const Frame* undistorted, const Frame* registered, thrust::device_vector<TupleXYZRGB>& cloud_data) const;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method is mostly for testing. I think most of the users would generate the point cloud with http://wiki.ros.org/depth_image_proc.

So don't change its signature. Add another method to do point cloud generation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all your comments. I will address them as soon as I get a chance.


private:
CudaRegistrationImpl *impl_;

/* Disable copy and assignment constructors */
CudaRegistration(const CudaRegistration&);
CudaRegistration& operator=(const CudaRegistration&);
};
#endif // LIBFREENECT2_WITH_CUDA_SUPPORT

} /* namespace libfreenect2 */
#endif /* REGISTRATION_H_ */
Loading