Skip to content

allow ci to run on all branches, not just main #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atravitz merged 3 commits into from
Oct 30, 2025
Merged

allow ci to run on all branches, not just main #1649

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9eb1a60
allow ci to run on all branches, not just main
atravitz Oct 30, 2025
c347746
griffe back to pull_request_target
atravitz Oct 30, 2025
2f40a2f
remove 'branches'
atravitz Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
name: "CI"
on:
pull_request:
Copy link
Contributor Author

@atravitz atravitz Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also I updated this to be more strict ( it was "Require approval for first-time contributors" before):

Image

and then we can use: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/approve-runs-from-forks

Copy link
Contributor

@mikemhenry mikemhenry Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine, I figured a trust on first use model (like the one we use for ssh) was okay, but I don't think we can be too careful. It does mean we can be quicker to let someone merge in a one line typo change since it then doesn't get them into the "run without approval" list

branches:
- main
# Skip CI if changed files only affect the following folders
# - docs: documentation changes don't need code validation
# See here for more details: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-excluding-paths
paths-ignore:
- "docs/*"
- "news/*"
Copy link
Contributor Author

@atravitz atravitz Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems practical

- ".readthedocs.yaml"
- ".github/workflows/cpu-long-tests.yaml"
- ".github/workflows/gpu-integration-tests.yaml"
Expand Down