allow ci to run on all branches, not just main#1649
Conversation
| # See here for more details: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-excluding-paths | ||
| paths-ignore: | ||
| - "docs/*" | ||
| - "news/*" |
There was a problem hiding this comment.
this seems practical
| @@ -2,12 +2,12 @@ name: "CI" | |||
| on: | |||
| pull_request: | |||
There was a problem hiding this comment.
also I updated this to be more strict ( it was "Require approval for first-time contributors" before):
and then we can use: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/approve-runs-from-forks
There was a problem hiding this comment.
That's fine, I figured a trust on first use model (like the one we use for ssh) was okay, but I don't think we can be too careful. It does mean we can be quicker to let someone merge in a one line typo change since it then doesn't get them into the "run without approval" list
|
No API break detected ✅ |
|
@mikemhenry please take a look after this is merged. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1649 +/- ##
==========================================
- Coverage 95.34% 92.89% -2.45%
==========================================
Files 183 183
Lines 15779 15779
==========================================
- Hits 15044 14658 -386
- Misses 735 1121 +386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Checklist
newsentryDevelopers certificate of origin