Skip to content

Conversation

@atravitz
Copy link
Contributor

Checklist

  • Added a news entry

Developers certificate of origin

@atravitz
Copy link
Contributor Author

I fixed the memory issue by pip installing openfe ecosystem packages until a non-ambertools-requiring gufe is released (either 1.6.1 or 1.7.0, depending on timing).

Now running into

openfe.protocols.openmm_rfe.RelativeHybridTopologyProtocolSettings.alchemical_settings:1: WARNING: more than one target found for cross-reference 'AlchemicalSettings': openfe.protocols.openmm_rfe.equil_rfe_settings.AlchemicalSettings, openfe.protocols.openmm_afe.equil_afe_settings.AlchemicalSettings

which I've seen on the pydantic PR as well, so I'm looking into that now.

@atravitz atravitz marked this pull request as ready for review September 15, 2025 20:17
@atravitz
Copy link
Contributor Author

it works! 🥳

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one question, otherwise this looks good.

@github-actions
Copy link

No API break detected ✅

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (hopefully it still builds!)

@atravitz atravitz merged commit 1cb3ac7 into main Sep 15, 2025
12 checks passed
@atravitz atravitz deleted the fix_docs_build branch September 15, 2025 20:32
@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.67%. Comparing base (1831412) to head (c6efb87).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1510      +/-   ##
==========================================
- Coverage   95.54%   92.67%   -2.88%     
==========================================
  Files         163      163              
  Lines       12593    12593              
==========================================
- Hits        12032    11670     -362     
- Misses        561      923     +362     
Flag Coverage Δ
fast-tests 92.67% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

atravitz added a commit that referenced this pull request Sep 29, 2025
* try mambaforge build

* Revert "try mambaforge build"

This reverts commit 683e07f.

* try explicit build

* try removing ambertools

* use the right env

* just add gufe pip install back

* add back openfe eco packages

* mock py3dmol

* add note for pip installs

* fix quote

* temporarily resort to SettingsBaseModel to get build

* specific imports

* dont use base settings placeholder
atravitz added a commit that referenced this pull request Oct 7, 2025
* update partial charge tests now that a production NAGL model is available (#1506)

* update tests now that a production NAGL model is available

* fix mock

* clean up mocking

* add nagl test news item

* debug slow python 3.13 tests (#1468)

* Turn off minimization when we do a dry run
---------

Co-authored-by: IAlibay <IAlibay@users.noreply.github.com>

* update quickrun execution docs and add MPS link (#1483)

* add jq cookbook (#1488)

* add jq code blocks

* use tutorial data

* news

* debug docs build (#1489)

* don't build openmm

* mambaforge->miniconda for rtd

* artifically small build for debugging

* dont build env

* just build python

* add channels

* add sphinx packages to env

* add all non-openfe-ecosystem deps

* remove shim channel

* add openfe package

* add everything except openmm and toolkit

* add openmm

* add openff-toolkit

* only openff-toolkit

* try openff-toolkit-base

* try latest openff

* everybody back in

* build without openmm

* build with openff-toolkit-base

* bump rtd

* add pip build

* remove any openff-toolkit

* build w/o openmm

* add pip install

* build everything without pip install

* try no deps

* try custom build

* only python and pip

* try openfe-toolkit-base

* add temp deps for build with openff-toolkit-base

* add temp deps for build with openff-toolkit-base

* mock imports

* dont mock with toolkit base

* bump toolkit version

* Revert "bump toolkit version"

This reverts commit 6e3108a.

* add mocks

* try pinnint to toolkit-base 0.13.0, no mocks

* back to >= 0.13.0 toolkit to make sure it wasn't a fluke

* mock imports

* add pipe example for jq (#1505)

* add pipe example for jq

* pin to docutil 0.20

* try to avoid memory error

* debug rtd build memory error (#1510)

* try mambaforge build

* Revert "try mambaforge build"

This reverts commit 683e07f.

* try explicit build

* try removing ambertools

* use the right env

* just add gufe pip install back

* add back openfe eco packages

* mock py3dmol

* add note for pip installs

* fix quote

* temporarily resort to SettingsBaseModel to get build

* specific imports

* dont use base settings placeholder

* temp pin numpy (#1542)

* Removing unnecessary limit on resids (#1539)

* Removing unnecessary limit on resids indices gathering

* Updated CHANGELOG for 1.6.1

* add summary

* update docs theme (#1545)

* adding new branding assets

* remove images

* update theme branch

* CantinaPurple accent

* lowercase convention

* updating text

* remove dark mode for now

* fix sidebars

* fix formatting

* capitalization

* don't break spaces

* bump ci

* favicon!

* whitespace :(

* pin to sphinx release

* pin to gufe 1.6.1

* move env info before test imports

* bump single file installer to 3.12.11 to match colab

---------

Co-authored-by: IAlibay <IAlibay@users.noreply.github.com>
Co-authored-by: Iván Pulido <2949729+ijpulidos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants