Skip to content

Track Cargo.lock in git#23

Merged
jerrysxie merged 1 commit intoOpenDevicePartnership:mainfrom
kurtjd:include-cargo-lock
Jul 28, 2025
Merged

Track Cargo.lock in git#23
jerrysxie merged 1 commit intoOpenDevicePartnership:mainfrom
kurtjd:include-cargo-lock

Conversation

@kurtjd
Copy link
Contributor

@kurtjd kurtjd commented Jul 25, 2025

Remove Cargo.lock from .gitignore so it is tracked in repository.

@kurtjd kurtjd self-assigned this Jul 25, 2025
@kurtjd kurtjd requested a review from a team as a code owner July 25, 2025 20:24
jerrysxie
jerrysxie previously approved these changes Jul 25, 2025
@jerrysxie jerrysxie enabled auto-merge (squash) July 25, 2025 20:45
@kurtjd kurtjd moved this to In review in Embedded Controller Jul 25, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the CI/CD workflows to use the --locked flag with Cargo commands, ensuring that builds use the exact dependency versions specified in Cargo.lock. This change aligns with the practice of tracking Cargo.lock in the repository to ensure reproducible builds across different environments.

  • Added --locked flag to all cargo check, cargo test, and cargo doc commands in CI workflows
  • Updated cargo-deny configuration to use --locked flag for dependency checking
  • Modified cargo-hack feature powerset checking to use locked dependencies

Reviewed Changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

File Description
.github/workflows/rolling.yml Added --locked flag to cargo check commands for rolling release testing
.github/workflows/nostd.yml Added --locked flag to no-std target checking
.github/workflows/check.yml Added --locked flag to documentation, feature checking, dependency auditing, MSRV validation, and testing workflows

@jerrysxie
Copy link
Contributor

Sorry @kurtjd it seems like Cargo.lock needs to be updated after #21 has been merged,

@kurtjd
Copy link
Contributor Author

kurtjd commented Jul 28, 2025

Sorry @kurtjd it seems like Cargo.lock needs to be updated after #21 has been merged,

No worries, just updated it.

@jerrysxie jerrysxie merged commit b55fa1c into OpenDevicePartnership:main Jul 28, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Embedded Controller Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants