Skip to content

Update to embedded-sensors v0.3.0#21

Merged
jerrysxie merged 1 commit intoOpenDevicePartnership:mainfrom
kurtjd:embedded-sensors
Jul 28, 2025
Merged

Update to embedded-sensors v0.3.0#21
jerrysxie merged 1 commit intoOpenDevicePartnership:mainfrom
kurtjd:embedded-sensors

Conversation

@kurtjd
Copy link
Contributor

@kurtjd kurtjd commented Jun 18, 2025

Updates to embedded-sensors v0.3.0, introducing breaking changes to the API requiring update of tmp108 version from v0.2.0 to v0.3.0.

MSRV changed to 1.84 to be able to use f32::abs from core (which was moved from std). Alternatives are to use silent integer truncation instead of checking for float equality within an epsilon, but that might result in behavior caller does not expect.

tullom
tullom previously approved these changes Jun 19, 2025
@jeffglaum jeffglaum moved this to In review in Embedded Controller Jun 19, 2025
jerrysxie
jerrysxie previously approved these changes Jun 19, 2025
@kurtjd kurtjd requested a review from felipebalbi June 19, 2025 20:19
@kurtjd kurtjd dismissed stale reviews from jerrysxie and tullom via 7c905fb June 19, 2025 20:26
@kurtjd kurtjd force-pushed the embedded-sensors branch from 9cc800d to 7c905fb Compare June 19, 2025 20:26
@kurtjd
Copy link
Contributor Author

kurtjd commented Jun 19, 2025

Had to rebase for merge conflicts.

jerrysxie
jerrysxie previously approved these changes Jun 19, 2025
@jerrysxie jerrysxie enabled auto-merge (squash) June 19, 2025 21:35
Copy link
Contributor

@jerrysxie jerrysxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kurtjd This seems to be a breaking change. Is this crate on crate.io? Please announce it on Zulip and Discord. Pending that, looking good to me.

@jerrysxie jerrysxie merged commit f2a3374 into OpenDevicePartnership:main Jul 28, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Embedded Controller Jul 28, 2025
@jerrysxie jerrysxie mentioned this pull request Jul 28, 2025
@kurtjd
Copy link
Contributor Author

kurtjd commented Jul 28, 2025

@kurtjd This seems to be a breaking change. Is this crate on crate.io? Please announce it on Zulip and Discord. Pending that, looking good to me.

Thank you, posted announcement to Discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BREAKING CHANGE enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants