Skip to content

Update the CRC algorithm to the one used elsewhere in ODP #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffglaum merged 1 commit into from
May 14, 2025
Merged

Update the CRC algorithm to the one used elsewhere in ODP #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ use core::mem::size_of;
use bytemuck::{Pod, Zeroable};
use constmuck::bytes_of;
/// re-export for matching software CRC32 checksum
pub use crc::{Crc, Digest, CRC_32_CKSUM};
pub use crc::{Crc, Digest, CRC_32_ISO_HDLC};

mod version {
include!(concat!(env!("OUT_DIR"), "/version.rs"));
Expand Down Expand Up @@ -260,7 +260,7 @@ impl BootableRegionDescriptorHeader {
i += 1;
}

Crc::<u32>::new(&CRC_32_CKSUM).checksum(&without_crc)
Crc::<u32>::new(&CRC_32_ISO_HDLC).checksum(&without_crc)
}

/// Check if the header_crc value matches the current computed CRC32 checksum
Expand Down Expand Up @@ -374,7 +374,7 @@ impl AppImageDescriptor {
i += 1;
}

Crc::<u32>::new(&CRC_32_CKSUM).checksum(&without_crc)
Crc::<u32>::new(&CRC_32_ISO_HDLC).checksum(&without_crc)
}

/// Check this structure's stored descriptor_crc against computed CRC32 checksum of its current contents
Expand Down