Update the CRC algorithm to the one used elsewhere in ODP#10
Merged
jeffglaum merged 1 commit intoOpenDevicePartnership:mainfrom May 14, 2025
Merged
Update the CRC algorithm to the one used elsewhere in ODP#10jeffglaum merged 1 commit intoOpenDevicePartnership:mainfrom
jeffglaum merged 1 commit intoOpenDevicePartnership:mainfrom
Conversation
seanfro
requested review from
JamesHuard,
RobertZ2011,
felipebalbi,
jerrysxie,
madeleyneVaca and
tullom
as code owners
madeleyneVaca
approved these changes
May 14, 2025
jeffglaum
approved these changes
May 14, 2025
felipebalbi
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CRC algorithm that consumes these descriptors is CRC_32_ISO_HDLC. Updating the descriptor CRC generation to match.