Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field initializing constructor, fix explicit, fix deserialization… #320

Merged
merged 2 commits into from
Oct 18, 2023

Commits on Oct 11, 2023

  1. Add field initializing constructor, fix explicit, fix deserialization…

    … bug
    
    When you use "cetl++14-17" or "c++17-pmr" we code-gen message classes with
    constructors that take an allocator.  Since the class has a user-defined
    constructor this means it can no longer use aggregate initialization
    (https://en.cppreference.com/w/cpp/language/aggregate_initialization)
    This is inconvenient so I'm adding a constructor with args for each field,
    in order.  This also makes it possible to declare a const message instance.
    
    Some single arg constructors weren't marked explicit, thus becoming user-defined
    conversion functions, which introduces unexpected bugs. I've fixed all the
    constructors so any single-arg ones are declared explicit.
    
    Fixed a deserialization bug where the allocator was not getting passed to a
    temporary.
    skeetsaz committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    7f4b46f View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Configuration menu
    Copy the full SHA
    b714f41 View commit details
    Browse the repository at this point in the history