Add field initializing constructor, fix explicit, fix deserialization… #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bug When you use "cetl++14-17" or "c++17-pmr" we code-gen message classes with constructors that take an allocator. Since the class has a user-defined constructor this means it can no longer use aggregate initialization (https://en.cppreference.com/w/cpp/language/aggregate_initialization) This is inconvenient so I'm adding a constructor with args for each field, in order. This also makes it possible to declare a const message instance. Some single arg constructors weren't marked explicit, thus becoming user-defined conversion functions, which introduces unexpected bugs. I've fixed all the constructors so any single-arg ones are declared explicit. Fixed a deserialization bug where the allocator was not getting passed to a temporary.
thirtytwobits
approved these changes
Oct 12, 2023
|
Kudos, SonarCloud Quality Gate passed! |
|
The docs and doctests pass locally. How do I override the check failure? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… bug
When you use "cetl++14-17" or "c++17-pmr" we code-gen message classes with constructors that take an allocator. Since the class has a user-defined constructor this means it can no longer use aggregate initialization (https://en.cppreference.com/w/cpp/language/aggregate_initialization) This is inconvenient so I'm adding a constructor with args for each field, in order. This also makes it possible to declare a const message instance.
Some single arg constructors weren't marked explicit, thus becoming user-defined conversion functions, which introduces unexpected bugs. I've fixed all the constructors so any single-arg ones are declared explicit.
Fixed a deserialization bug where the allocator was not getting passed to a temporary.