Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] mutation icon appears in activity (#6261) #6301

Merged
merged 6 commits into from
Mar 13, 2024
Merged

Conversation

CelineSebe
Copy link
Member

@CelineSebe CelineSebe commented Mar 11, 2024

Proposed changes

  • Add new icon for Synchronizer
  • Add new icon for Task
  • Change the default icon for all other types

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@CelineSebe CelineSebe added the filigran team use to identify PR from the Filigran team label Mar 11, 2024
@CelineSebe CelineSebe self-assigned this Mar 11, 2024
@CelineSebe CelineSebe marked this pull request as ready for review March 12, 2024 15:08
@CelineSebe CelineSebe linked an issue Mar 12, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 67.45%. Comparing base (2710f7b) to head (d808505).
Report is 14 commits behind head on master.

Files Patch % Lines
...ti-graphql/src/modules/notifier/notifier-domain.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6301      +/-   ##
==========================================
+ Coverage   66.68%   67.45%   +0.77%     
==========================================
  Files         541      541              
  Lines       64420    64501      +81     
  Branches     5257     6044     +787     
==========================================
+ Hits        42957    43512     +555     
+ Misses      21463    20989     -474     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -519,7 +524,7 @@ const iconSelector = (type, variant, fontSize, color, isReversed) => {
case 'default':
return <CircleOutlined style={style} fontSize={fontSize} role="img" />;
default:
return <HelpOutlined style={style} fontSize={fontSize} role="img" />;
return <AutoAwesomeMotion style={style} fontSize={fontSize} role="img" />;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rollback this icon to the previous one, we need to keep the "?" icon for the ones unknown.

@CelineSebe CelineSebe merged commit 14836ee into master Mar 13, 2024
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/6261 branch April 3, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mutation icon not always well displayed in Activity
2 participants