Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutation icon not always well displayed in Activity #6261

Closed
Archidoit opened this issue Mar 4, 2024 · 3 comments · Fixed by #6301
Closed

Mutation icon not always well displayed in Activity #6261

Archidoit opened this issue Mar 4, 2024 · 3 comments · Fixed by #6301
Assignees
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone

Comments

@Archidoit
Copy link
Member

Go to Settings > Activity > Events to see the list of activity events.
The icon of some events of type 'mutation' are displayed as '?' :
image

image

@Archidoit Archidoit added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Mar 4, 2024
@Archidoit Archidoit changed the title Mutation icon not well displayed in Activity Mutation icon not always well displayed in Activity Mar 4, 2024
@CelineSebe CelineSebe self-assigned this Mar 4, 2024
@SamuelHassine SamuelHassine removed the needs triage use to identify issue needing triage from Filigran Product team label Mar 4, 2024
@SamuelHassine SamuelHassine added this to the Release 6.0.6 milestone Mar 4, 2024
@CelineSebe
Copy link
Member

I found a solution by adding the types of missing icons. For example, 'Task-template' didn't exist, which is the origin of the bug in my case. I need the types displayed in the screenshot to resolve all the problems.

@Archidoit
Copy link
Member Author

@CelineSebe maybe you can also add a 'default' icon in case no types is indicated to prevent this bad display for special/missing/future-added types

@CelineSebe
Copy link
Member

@CelineSebe maybe you can also add a 'default' icon in case no types is indicated to prevent this bad display for special/missing/future-added types

Yes, you're right. There is already a default icon, HelpOutlined, which has been chosen in case no entity_type or event_scope are indicated. I will discuss this further with JP.

@CelineSebe CelineSebe linked a pull request Mar 12, 2024 that will close this issue
5 tasks
CelineSebe added a commit that referenced this issue Mar 12, 2024
CelineSebe added a commit that referenced this issue Mar 12, 2024
CelineSebe added a commit that referenced this issue Mar 13, 2024
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants