[frontend] Fix tooltip issue when adding a filter(#6036) #6162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkha
reviewed
Feb 28, 2024
| @@ -290,7 +290,7 @@ export const FilterChipPopover: FunctionComponent<FilterChipMenuProps> = ({ | |||
| ? filterValues.filter((fVal) => fVal && fVal.key === subKey && fVal.values.includes(option.value)).length > 0 | |||
| : filterValues.includes(option.value); | |||
| return ( | |||
| <Tooltip title={option.label} key={option.label}> | |||
| <Tooltip title={option.label} key={option.label} followCursor={true}> | |||
There was a problem hiding this comment.
You can write just "followCursor"
jpkha
approved these changes
Feb 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6162 +/- ##
=======================================
Coverage 66.68% 66.68%
=======================================
Files 540 540
Lines 64349 64349
Branches 5251 5252 +1
=======================================
Hits 42914 42914
Misses 21435 21435 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...