Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter tooltip placement bug when creating a widget #6036

Closed
CelineSebe opened this issue Feb 19, 2024 · 7 comments · Fixed by #6162
Closed

Filter tooltip placement bug when creating a widget #6036

CelineSebe opened this issue Feb 19, 2024 · 7 comments · Fixed by #6162
Assignees
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR) ui for scope limited to UI change
Milestone

Comments

@CelineSebe
Copy link
Member

CelineSebe commented Feb 19, 2024

Description

The tooltips appear outside of the widget creation box (above or below).

Reproducible Steps

Steps to create the smallest reproducible scenario:
1- Go to a Dashboard > Create a widget
2- Horizontal bar > Knowledge Bar
3- Add a filter
4- Click on filter to scroll through all options

Expected Output

Actual Output

Bug tooltip arrow

2024-02-19.15-16-22.mp4

Additional information

Screenshots (optional)

@CelineSebe CelineSebe added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Feb 19, 2024
@CelineSebe CelineSebe changed the title Bug in the position of the filter tooltip when creating a widget. Filter tooltip placement bug when creating a widget Feb 19, 2024
@jborozco jborozco removed the needs triage use to identify issue needing triage from Filigran Product team label Feb 20, 2024
@nino-filigran nino-filigran added this to the Release 6.0.1 milestone Feb 20, 2024
@jpkha jpkha self-assigned this Feb 28, 2024
@jpkha
Copy link
Member

jpkha commented Feb 28, 2024

In my opinion, we cannot fix this bug with the current component we are using.
The structure in the DOM here makes it impossible to manipulate the z-index and overflow; the tooltip element is at the same level as the presentation.
image

@jpkha
Copy link
Member

jpkha commented Feb 28, 2024

@nino-filigran @jborozco IMO, the behavior is acceptable. But if you want to fix this, we need to find another tooltip component.

@nino-filigran
Copy link

After a discussion with @jpkha the ROI to change component is quite low, since its used in lots of places (and therefore we would need to change lots of components before the release). For now, we'll test only the ability to reduce the time during which the tooltip is displayed. IF the test is unsuccessful, then we'll tackle this as proper feature (to update the tooltip component)

cc @Kedae

@CelineSebe
Copy link
Member Author

I found a solution with the prop: followCursor on the tooltip component

@nino-filigran
Copy link

That's great new @CelineSebe ! Could you either show or record a video? And this does not affect other places in the app?

@jpkha jpkha assigned CelineSebe and unassigned jpkha Feb 28, 2024
@CelineSebe
Copy link
Member Author

2024-02-28-15-42-32.mp4

@nino-filigran
Copy link

C'est royal :) merci beaucoup

@CelineSebe CelineSebe linked a pull request Feb 28, 2024 that will close this issue
5 tasks
CelineSebe added a commit that referenced this issue Feb 28, 2024
@Filigran-Automation Filigran-Automation added the solved use to identify issue that has been solved (must be linked to the solving PR) label Feb 28, 2024
@Jipegien Jipegien modified the milestones: Release 6.0.1, Release 6.0.2 Feb 29, 2024
@Jipegien Jipegien added the ui for scope limited to UI change label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR) ui for scope limited to UI change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants