Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] update messages and translations for decay (#2859) #5948

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Feb 13, 2024

Proposed changes

  • Add missing translations for decay settings
  • Update built-in decay rules names

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e7eadf) 65.44% compared to head (8981a27) 66.03%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5948      +/-   ##
==========================================
+ Coverage   65.44%   66.03%   +0.58%     
==========================================
  Files         539      539              
  Lines       63059    63253     +194     
  Branches     5051     5503     +452     
==========================================
+ Hits        41271    41771     +500     
+ Misses      21788    21482     -306     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SouadHadjiat SouadHadjiat marked this pull request as ready for review February 15, 2024 17:10
@aHenryJard aHenryJard merged commit cb3d6a7 into master Feb 16, 2024
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/2859-messages branch February 16, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants