Skip to content

Handle upgrade with multiple installed same plugins #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

ryanmelt
Copy link
Member

closes #1125

@ryanmelt ryanmelt requested a review from jmthomas March 10, 2024 03:06
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 75.02%. Comparing base (6b9e120) to head (c28fd75).

Files Patch % Lines
openc3/lib/openc3/utilities/process_manager.rb 0.00% 6 Missing ⚠️
openc3/lib/openc3/models/gem_model.rb 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1135      +/-   ##
==========================================
- Coverage   75.02%   75.02%   -0.01%     
==========================================
  Files         594      594              
  Lines       43826    43829       +3     
  Branches      757      757              
==========================================
  Hits        32881    32881              
- Misses      10862    10865       +3     
  Partials       83       83              
Flag Coverage Δ
frontend 55.52% <ø> (+0.03%) ⬆️
python 83.01% <ø> (-0.02%) ⬇️
ruby-api 48.70% <ø> (ø)
ruby-backend 80.06% <8.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanmelt ryanmelt merged commit a7dd92d into main Mar 10, 2024
@ryanmelt ryanmelt deleted the handle_upgrade_with_multiple_installs branch March 10, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gem file can't be uninstalled because needed by installed plugin
1 participant