Merge pull request #1135 from OpenC3/handle_upgrade_with_multiple_installs

Handle upgrade with multiple installed same plugins

Author: ryanmelt

openc3/lib/openc3/models/gem_model.rb

@@ -102,13 +102,15 @@ def self.install(name_or_path, scope:)
       raise err
     end
 
-    def self.destroy(name)
+    def self.destroy(name, log_and_raise_needed_errors: true)
       gem_name, version = self.extract_name_and_version(name)
       plugin_gem_names = PluginModel.gem_names
       if plugin_gem_names.include?(name)
-        message = "Gem file #{name} can't be uninstalled because needed by installed plugin"
-        Logger.error message
-        raise message
+        if log_and_raise_needed_errors
+          message = "Gem file #{name} can't be uninstalled because needed by installed plugin"
+          Logger.error message
+          raise message
+        end
       else
         begin
           Gem::Uninstaller.new(gem_name, {:version => version, :force => true}).uninstall
@@ -131,7 +133,7 @@ def self.destroy_all_other_versions(name)
       GemModel.names.each do |gem_full_name|
         gem_name, gem_version = GemModel.extract_name_and_version(gem_full_name)
         if gem_name == keep_gem_name and gem_version != keep_gem_version
-          GemModel.destroy(gem_full_name)
+          GemModel.destroy(gem_full_name, log_and_raise_needed_errors: false)
         end
       end
     end

openc3/lib/openc3/utilities/process_manager.rb

@@ -117,11 +117,15 @@ def monitor
           process.status.update
         end
         processes_to_delete.each do |process|
-          Logger.info("Process #{process.status.name}:#{process.process_type}:#{process.detail} completed with state #{process.status.state}", scope: process.scope)
-          if process.status.state == "Warning"
-            Logger.warn("Process Output:\n#{process.status.output}", scope: process.scope)
+          message = "Process #{process.status.name}:#{process.process_type}:#{process.detail} completed with state #{process.status.state}\nProcess Output:\n#{process.status.output}"
+          if process.status.state != "Complete"
+            if process.status.state == "Warning"
+              Logger.warn(message, scope: process.scope)
+            else
+              Logger.error(message, scope: process.scope)
+            end
           else
-            Logger.error("Process Output:\n#{process.status.output}", scope: process.scope)
+            Logger.info(message, scope: process.scope)
           end
 
           @processes.delete(process)