-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rust] Update to modern hyper and futures crates #9919
Conversation
@softdevca thanks for the PR. Can you please PM me via Slack to discuss this change further? |
Can you please resolve the merge conflicts when you've time? Upcoming 5.3.0 release allow breaking changes without fallback so I think we can include this change if all tests are good. |
Conflict resolved and rebased to master. |
Looks like the rebase went wrong and therefore this PR contains many commits that do not belong to you. Can you please create a new PR by cherry-picking the commits that belong to you? |
@softdevca is this PR still being worked on? If this just needs a rebase + cherrypick I'm happy to help to get this pushed over the line |
I haven't had an opportunity. Please feel free, and thank you!
…On Wed, 17 Nov 2021 at 13:58, Broderick Carlin ***@***.***> wrote:
@softdevca <https://github.com/softdevca> is this PR still being worked
on? If this just needs a rebase + cherrypick I'm happy to help to get this
pushed over the line
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9919 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR5U7RFIJNXIHHBONX2KXTUMQQRZANCNFSM5ACAF4NA>
.
|
@softdevca would you be able to provide me with push permissions to your fork/branch? That should allow us to not have to open a whole new PR |
Invite sent - thanks again. |
@softdevca @wing328 the rebase was cleaned up and the PR should be ready for a final review |
Tested with updated samples locally and the result is good
I consider this a security fix to hyper (https://www.cvedetails.com/vulnerability-list/vendor_id-17878/Hyper.html) so that we can merge this into master (upcoming v5.3.1 is a patch release) |
FYI. Samples updated via 962e8c4 |
Thanks for the assistance while other tasks took priority - appreciated! |
The hyper and futures crates used by the Rust client were significantly out of date. This pull request addresses the issue by updating futures to 0.3.* and hyper to 0.14.*.
The newer futures crate required a breaking change in the generated APIs - the return types are now
Future<Result>
instead ofFuture<Output,Error>
The newer version of hyper is required to work with modern versions of tokio.
Fixes #8400
PR checklist
master
,5.1.x
,6.0.x
@frol (2017/07) @farcaller (2017/08) @richardwhiuk (2019/07) @paladinzh (2020/05)