Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] Upgrade Hyper/packages in Rust Client #8400

Closed
andrew-s opened this issue Jan 10, 2021 · 2 comments · Fixed by #9919
Closed

[REQ] Upgrade Hyper/packages in Rust Client #8400

andrew-s opened this issue Jan 10, 2021 · 2 comments · Fixed by #9919

Comments

@andrew-s
Copy link

Is your feature request related to a problem? Please describe.

The hyper package used in the rust client "rust" generator is very old, sat at version 0.11 - there was a big shift in the way it works between 0.11 and 0.12. It makes sense to upgrade this to 0.14.

Describe the solution you'd like

Upgrade the package to a newer version beyond 0.12

Describe alternatives you've considered

The alternative to not upgrading is a real pain, where my application relies heavily upon hyper so I have that package within my application - to work with an older version I'd need to import hyper 0.11 and the tokio_core packages (for the handler to connect). It was easier to just use reqwest (1 extra library vs 2) however, it would be nice to not have to use any extra packages when I already have a newer hyper on hand.

Granted, I need to make these changes because I'm changing the default configuration of apis within my application, as the Configuration struct is immutable I'm unable to change it after the fact. Ideally, configuration should be decoupled from the http client library creation but, that's probably a larger task than it is to just upgrade the packages (also unsure how other packages are built and if configuration + client is a commonality)

@DartMen
Copy link

DartMen commented Apr 16, 2021

I as well feel some pain using the outdated hyper package.

Any progress on this request?

@softdevca
Copy link
Contributor

Pull request #9919 addresses this issue. Please consider testing the changes if you are able.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants