Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subclass Python exceptions #7321

Merged
merged 4 commits into from
Sep 5, 2020
Merged

Subclass Python exceptions #7321

merged 4 commits into from
Sep 5, 2020

Conversation

ryanrishi
Copy link
Contributor

Subclasses Python exceptions as outlined in #2151:

  • UnauthorizedException (401)
  • ForbiddenException (403)
  • NotFoundException (404)
  • ServiceException [500 - 599]

@taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01) @arun-nalla (2019/11) @spacether (2019/11)

- UnauthorizedException (401)
- ForbiddenException (403)
- NotFoundException (404)
- ServiceException [500 - 599]

Fixes #2151
@spacether spacether added this to the 5.0.0 milestone Sep 5, 2020
Copy link
Contributor

@spacether spacether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great, thank you for the PR!

@spacether spacether merged commit 2d5b272 into OpenAPITools:master Sep 5, 2020
@ryanrishi ryanrishi deleted the rr/python-exception-subclasses branch September 6, 2020 16:54
jimschubert added a commit to lwlee2608/openapi-generator that referenced this pull request Sep 12, 2020
* master: (1557 commits)
  [docs] Add notes on Windows classpath modification (OpenAPITools#7404)
  [C#][netcore] better support for additional properties in the payload (OpenAPITools#7396)
  Fix the ECDSA signature issue for PowerShellSDK (OpenAPITools#7386)
  Fix the new package that deal with Configuration (the old one is depecrated) (OpenAPITools#7391)
  update vonage logo (OpenAPITools#7387)
  [gradle][plugin] Fix tests (OpenAPITools#7384)
  [typescript] Fix incorrect enum literal case (OpenAPITools#7378)
  Rust reqwest/api_mustache Missing api Vec in parameter (OpenAPITools#7049)
  [kotlin] Fix imports of generated class (OpenAPITools#7314)
  Properly decode $ref (OpenAPITools#7191)
  fix typo, update caption
  feat(r): retry configuration for status codes (OpenAPITools#5925)
  [json][codegen] Add option: outputFileName (OpenAPITools#7348)
  RSACng class is not supported on linux replacing it by RSA (OpenAPITools#7349)
  Adds cookie auth support to ApiKeyAuth in dart2 templates (OpenAPITools#7346)
  [js][flowtype] Bump lodash from 4.17.15 to 4.17.19 (OpenAPITools#7359)
  Bugfix swift5 code generation 2966 (OpenAPITools#7301)
  Syncs validation properties for arraymodels (OpenAPITools#7357)
  Subclass Python exceptions (OpenAPITools#7321)
  Adds fix for issue7262 and a test of it (OpenAPITools#7328)
  ...
Kylmakalle pushed a commit to Kylmakalle/openapi-generator that referenced this pull request Dec 4, 2020
* Subclass Python exceptions:
- UnauthorizedException (401)
- ForbiddenException (403)
- NotFoundException (404)
- ServiceException [500 - 599]

Fixes OpenAPITools#2151

* add generated sample code

* use Python 2 flavor inheritance

* regenerate samples
spacether pushed a commit that referenced this pull request Dec 5, 2020
* Subclass Python exceptions (#7321)

* Subclass Python exceptions:
- UnauthorizedException (401)
- ForbiddenException (403)
- NotFoundException (404)
- ServiceException [500 - 599]

Fixes #2151

* add generated sample code

* use Python 2 flavor inheritance

* regenerate samples

* update samples

Co-authored-by: Ryan Rishi <ryan@ryanrishi.com>
Co-authored-by: William Cheng <wing328hk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants