Properly decode $ref #7191
Merged
Properly decode $ref #7191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbu-WBT
force-pushed
the
properly-decode-ref
branch
from
e406d53
to
d492ce2
Compare
wing328
reviewed
Aug 26, 2020
| ref = URLDecoder.decode(ref, "UTF-8"); | ||
| } catch (UnsupportedEncodingException ignored) { | ||
| } | ||
|
|
There was a problem hiding this comment.
Shall we decode it at the start of the function getSimpleRef instead?
There was a problem hiding this comment.
I had the same thought, but why decoding a String part which gets thrown away? I see no reason to do so
By the way, I think we should also unescape these special cases:
jimschubert
reviewed
Sep 3, 2020
modules/openapi-generator/src/main/java/org/openapitools/codegen/utils/ModelUtils.java
Show resolved
Hide resolved
Co-authored-by: Jim Schubert <james.schubert@gmail.com>
|
I've added OAS 3.0 spec support because the JSON pointer escapes make sense for refs pointing to operations/paths. I think this approach is good to merge even before we cut 5.0.0-beta2. Any thoughts @wing328? |
wing328
approved these changes
Sep 8, 2020
jimschubert
added a commit
to lwlee2608/openapi-generator
that referenced
this pull request
Sep 12, 2020
* master: (1557 commits) [docs] Add notes on Windows classpath modification (OpenAPITools#7404) [C#][netcore] better support for additional properties in the payload (OpenAPITools#7396) Fix the ECDSA signature issue for PowerShellSDK (OpenAPITools#7386) Fix the new package that deal with Configuration (the old one is depecrated) (OpenAPITools#7391) update vonage logo (OpenAPITools#7387) [gradle][plugin] Fix tests (OpenAPITools#7384) [typescript] Fix incorrect enum literal case (OpenAPITools#7378) Rust reqwest/api_mustache Missing api Vec in parameter (OpenAPITools#7049) [kotlin] Fix imports of generated class (OpenAPITools#7314) Properly decode $ref (OpenAPITools#7191) fix typo, update caption feat(r): retry configuration for status codes (OpenAPITools#5925) [json][codegen] Add option: outputFileName (OpenAPITools#7348) RSACng class is not supported on linux replacing it by RSA (OpenAPITools#7349) Adds cookie auth support to ApiKeyAuth in dart2 templates (OpenAPITools#7346) [js][flowtype] Bump lodash from 4.17.15 to 4.17.19 (OpenAPITools#7359) Bugfix swift5 code generation 2966 (OpenAPITools#7301) Syncs validation properties for arraymodels (OpenAPITools#7357) Subclass Python exceptions (OpenAPITools#7321) Adds fix for issue7262 and a test of it (OpenAPITools#7328) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5720
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master