Revamp Cookie Modal with Proper Persistence (#41) #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #41 Implements separate cookie consent handling for anonymous and authenticated users: - Anonymous users: consent stored in localStorage - Authenticated users: consent stored in database via GraphQL mutation Backend Changes: - Added cookie_consent_accepted (BooleanField) to User model - Added cookie_consent_date (DateTimeField) to User model - Created migration 0018_user_cookie_consent_accepted_and_more - Added AcceptCookieConsent GraphQL mutation with @login_required - Registered mutation in schema Frontend Changes: - Added ACCEPT_COOKIE_CONSENT GraphQL mutation to mutations.ts - Updated CookieConsent component to check authentication status - For authenticated users: calls mutation to save consent to database - For anonymous users: saves consent to localStorage - Added loading states and error handling with fallback to localStorage - Added toast notifications for success/error states This ensures cookie consent is properly tracked and persisted based on user type, preventing the modal from repeatedly appearing after acceptance.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #41: Implements proper cookie consent persistence for both anonymous and authenticated users.
Backend Changes
Frontend Changes
Test Plan