Fixes for GCC 8 #746
Merged
Fixes for GCC 8 #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 14, 2023 14:41
This partially reverts commit e7b1121 but narrows down the check to only match GCC 8. Contributed by STMicroelectronics Signed-off-by: Erik MÅLLBERG <erik.lundin@st.com>
std::put_time is defined in header <iomanip>. Found when building with GCC 8. Contributed by STMicroelectronics Signed-off-by: Erik MÅLLBERG <erik.lundin@st.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #746 +/- ##
=======================================
Coverage 51.33% 51.33%
=======================================
Files 116 116
Lines 21471 21471
Branches 11821 11821
=======================================
Hits 11022 11022
Misses 8440 8440
Partials 2009 2009
Flags with carried forward coverage won't be shown. Click here to find out more.
|
edriouk
approved these changes
Feb 14, 2023
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes building for GCC 8. I found out that people still build with Ubuntu 18 and some changes in #737 didn't account for that.
stdc++fs(but only for GCC 8)Contributed by STMicroelectronics
Signed-off-by: Erik MÅLLBERG erik.lundin@st.com
@edriouk Please review :)