Clang 15 warnings #737
Merged
Clang 15 warnings #737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I think it would be good to not squash commits when merging, to keep matters separated. |
Author
edriouk
previously approved these changes
Feb 13, 2023
edriouk
requested changes
Feb 13, 2023
added 3 commits
February 14, 2023 10:30
Seems to have been necessary with GCC 8 but works without this on newer
GCC. Clang 15.0.7 fails if trying to link with it:
LLD Link... ld.lld: error: unable to find library -lstdc++fs
Contributed by STMicroelectronics
Signed-off-by: Erik MÅLLBERG <erik.lundin@st.com>
RteItem::Construct(XMLTreeElement*) was hiding XmlItem::Construct()
Clang complained with:
warning: 'RteItem::Construct' hides overloaded virtual function [-Woverloaded-virtual]
See https://stackoverflow.com/a/30192779
Contributed by STMicroelectronics
Signed-off-by: Erik MÅLLBERG <erik.lundin@st.com>
Numerous warnings when building with Clang 15:
warning: '[...]::IsEmpty' hides overloaded virtual function [-Woverloaded-virtual]
and
warning: '[...]' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Also remove duplicate XmlItem::IsEmpty(). It was moved from
RteAttributes in 19ef2e4.
Contributed by STMicroelectronics
Signed-off-by: Erik MÅLLBERG <erik.lundin@st.com>
ghost
mentioned this pull request
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #737 +/- ##
=======================================
Coverage 51.33% 51.33%
=======================================
Files 116 116
Lines 21471 21471
Branches 11821 11821
=======================================
Hits 11022 11022
Misses 8440 8440
Partials 2009 2009
Flags with carried forward coverage won't be shown. Click here to find out more. |
ghost
requested a review
from
edriouk
approved these changes
Feb 14, 2023
edriouk
pushed a commit
that referenced
this pull request
Feb 14, 2023
When cross compiling for Windows, some files weren't found due to unmatched case in the filename. The solution to use lowercase (see Stack Overflow link below) should work both on both Windows and other OSes. https://stackoverflow.com/q/15466613 Files below libs/crossplatform/include/win/ are renamed for consistency. Moved from #737, see discussion [here](#737 (comment)). Contributed by STMicroelectronics Signed-off-by: Erik MÅLLBERG <erik.lundin@st.com> Signed-off-by: Erik MÅLLBERG <erik.lundin@st.com>
ghost
mentioned this pull request
Merged
edriouk
pushed a commit
that referenced
this pull request
Feb 14, 2023
This fixes building for GCC 8. I found out that people still [build with Ubuntu 18](#696) and [some changes](e7b1121) in #737 didn't account for that. - Restore explicit linking with `stdc++fs` (but only for GCC 8) - Add missing header (didn't build on GCC 8.4.0 without this) Contributed by STMicroelectronics Signed-off-by: Erik MÅLLBERG <erik.lundin@st.com> @edriouk Please review :) --------- Signed-off-by: Erik MÅLLBERG <erik.lundin@st.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes miscellaneous warnings when building with Clang 15.
Contributed by STMicroelectronics
Signed-off-by: Erik MÅLLBERG erik.lundin@st.com