-
Notifications
You must be signed in to change notification settings - Fork 388
Fix undefined
error in browser when compiled with Babel
#144
Conversation
Execute listeners in the order they are added
Reverses order of listener execution, so now they're executed in the order they are added.
Documentation: type='text/javascript' is not needed in HTML5
Also add default "this" since things like phantomjs can whine about it.
Fix IIFE so webpack / babel works again
Update API docs and lock dependencies
Update Mocha link
Webpack fails to find the file and my build procedure crashes.
Remove array in main property of bower.json.
Add TypeScript declarations
Fix TypeScript declarations
fix(type): add missing args type for emit method
Sorry...
I can't amend my commits through this :(
added generic for EventEmitter to allow Custom EventKeys like an enum…
Adapt .d.ts file to match @lifenautjoe's changes
I was wondering why there were so many commits then I realised you targeted develop which I had forgotten about 😅 so you've updated develop for me I guess. Also didn't realise this was an issue, why is |
Was just following your instructions Sir! --> It was kinda strange to me at first. I was using a gulp-babel setup to compile source JS files and noticed anytime I tried |
Yup, I know :D it's not a problem at all, just forgot it was that way. I'll update those things to how I like to do things now, thanks for reminding me. I think I see your issue though and I think this fix is fine? I just hope it doesn't break it for anyone else. I'm guessing you have tried this version and it's all okay? |
Yes I have. And it works fine. Doesn't break anything over here ;) |
Provides a fallback for script to still work in browser, after compiling with Babel. Babel converts
this
toundefined