Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

fix(type): add missing args type for emit method #135

Merged
merged 1 commit into from
Jul 10, 2017
Merged

fix(type): add missing args type for emit method #135

merged 1 commit into from
Jul 10, 2017

Conversation

e-cloud
Copy link
Contributor

@e-cloud e-cloud commented Jul 10, 2017

No description provided.

@e-cloud
Copy link
Contributor Author

e-cloud commented Jul 10, 2017

@Olical hope to get review and merge ASAP, it's blocking the typescript compiler from running.

Olical
Olical approved these changes Jul 10, 2017
View reviewed changes
Copy link
Owner

@Olical Olical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems simple enough, I see why you need this.

@Olical Olical merged commit dc82dfb into Olical:master Jul 10, 2017
@Olical
Copy link
Owner

Olical commented Jul 10, 2017

@e-cloud Would you like to depend on this repository and check that it's all working for you before I publish the package?

@e-cloud
Copy link
Contributor Author

e-cloud commented Jul 10, 2017

Yeah, I've used some of the apis, and i haven't found another mistyped method.

@Olical
Copy link
Owner

Olical commented Jul 10, 2017

In v5.2.2, I hope it works!

@e-cloud
Copy link
Contributor Author

e-cloud commented Jul 11, 2017

thx

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Olical Olical Olical approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-cloud @Olical