Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/PSD-3525_gtm_cookie_investigation #3229

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore/PSD-3525_gtm_cookie_investigation #3229

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95bf3c8
Ensured GTM script is called if not dev environment
tahir-khalid Oct 15, 2024
f2f96d2
reverted changes
tahir-khalid Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/controllers/concerns/cookies_concern.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ def set_analytics_cookies(accept_analytics_cookies)
cookies[:cookies_policy] = {
Copy link
Contributor

@alan-at-work alan-at-work Oct 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems if you're not calling this is it really needed? this was removed from the app/views/layouts/application.html.erb

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjust code to ensure cookies policy is created.

value: get_policy.to_json,
expires: 1.year.from_now,
httponly: true
httponly: true,
raw: true
}
end
end
Expand Down