chore/PSD-3525_gtm_cookie_investigation #3229
Conversation
tahir-khalid
force-pushed
the
chore/PSD-3525_gtm_cookie_investigation
branch
from
ddf38c1
to
a210556
Compare
| @@ -14,12 +14,12 @@ | |||
| <%= javascript_include_tag "application", type: "module", nonce: true %> | |||
| <%= stylesheet_link_tag "application" %> | |||
| <%= csrf_meta_tags %> | |||
| <% if Rails.env.production? && analytics_cookies_accepted? %> | |||
| <% if !Rails.env.development? %> | |||
There was a problem hiding this comment.
maybe use <% unless Rails.env.development? %> also why are we not checking the analytics_cookies_accepted now? - leads to this #3229 (comment)
There was a problem hiding this comment.
Reading John's email the issue seems to be the GTM container doesn't respond unless analytics cookie is accepted so the intention here is bypass that trigger the container regardless.
There was a problem hiding this comment.
that means you're not setting the cookie, I think they need to remove that and trust that we are dealing with it or update their code to use the one we have set.
| <%= render "shared/ga_head" %> | ||
| <% end %> | ||
| </head> | ||
| <body class="govuk-template__body app-body-class"> | ||
| <% if Rails.env.production? && analytics_cookies_accepted? %> | ||
| <% if !Rails.env.development? %> |
There was a problem hiding this comment.
as above maybe use <% unless Rails.env.development? %>
| @@ -49,7 +49,8 @@ def set_analytics_cookies(accept_analytics_cookies) | |||
| cookies[:cookies_policy] = { | |||
There was a problem hiding this comment.
Seems if you're not calling this is it really needed? this was removed from the app/views/layouts/application.html.erb
There was a problem hiding this comment.
Adjust code to ensure cookies policy is created.
tahir-khalid
force-pushed
the
chore/PSD-3525_gtm_cookie_investigation
branch
from
6a54aeb
to
95bf3c8
Compare
alan-at-work
changed the title
Ensured GTM script is firing at correct time and cookies_policy is being set.