feat: add localization file validation

packages/fx-core/resource/package.nls.json

@@ -210,6 +210,9 @@
   "_error.appstudio.BotProvisionReturnsForbiddenResult.comment": "This is to describe API call, no need to translate 'Botframework'.",
   "error.appstudio.BotProvisionReturnsConflictResult": "Botframework provisioning returns conflict result when attempting to create bot registration.",
   "_error.appstudio.BotProvisionReturnsConflictResult.comment": "This is to describe API call, no need to translate 'Botframework'.",
+  "error.appstudio.localizationFile.pathNotDefined": "Localization file not found. Path: %s.",
+  "error.appstudio.localizationFile.validationFailed": "Localization file validation failed. File: %s. Error:\n%s",
+  "error.appstudio.localizationFile.validationException": "Localization file validation failed with exceptions. File: %s. Error: %s",
   "error.generator.ScaffoldLocalTemplateError": "Unable to scaffold template based on local zip package.",
   "error.generator.TemplateNotFoundError": "Unable to find template: %s.",
   "error.generator.SampleNotFoundError": "Unable to find sample: %s.",

packages/fx-core/src/component/driver/teamsApp/validate.ts

@@ -1,7 +1,17 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-import { Result, FxError, ok, err, Platform, ManifestUtil, Colors } from "@microsoft/teamsfx-api";
+import {
+  Result,
+  FxError,
+  ok,
+  err,
+  Platform,
+  ManifestUtil,
+  Colors,
+  TeamsAppManifest,
+  UserError,
+} from "@microsoft/teamsfx-api";
 import { hooks } from "@feathersjs/hooks/lib";
 import { Service } from "typedi";
 import { EOL } from "os";
@@ -337,4 +347,72 @@ export class ValidateManifestDriver implements StepDriver {
     }
     return ok(undefined);
   }
+
+  private async validateLocalizatoinFiles(
+    args: ValidateManifestArgs,
+    context: WrapDriverContext,
+    manifest: TeamsAppManifest
+  ): Promise<Result<any, FxError>> {
+    const errors: string[] = [];
+    const additionalLanguages = manifest.localizationInfo?.additionalLanguages;
+    if (!additionalLanguages || additionalLanguages.length == 0) {
+      return ok(undefined);
+    }
+    for (const language of additionalLanguages) {
+      const filePath = language?.file;
+      if (!filePath) {
+        return err(
+          AppStudioResultFactory.UserError(
+            AppStudioError.ValidationFailedError.name,
+            AppStudioError.ValidationFailedError.message([
+              getLocalizedString("error.appstudio.localizationFile.pathNotDefined", filePath),
+            ]),
+            HelpLinks.WhyNeedProvision
+          )
+        );
+      }
+      const localizationFileDir = path.dirname(
+        getAbsolutePath(args.manifestPath, context.projectPath)
+      );
+      const localizationFilePath = getAbsolutePath(filePath, localizationFileDir);
+      const manifestRes = await manifestUtils.getManifestV3(localizationFilePath, context);
+      if (manifestRes.isErr()) {
+        return err(manifestRes.error);
+      }
+      const localizationFile = manifestRes.value;
+      try {
+        const validationRes = await ManifestUtil.validateManifest(localizationFile);
+        if (validationRes.length > 0) {
+          return err(
+            AppStudioResultFactory.UserError(
+              AppStudioError.ValidationFailedError.name,
+              AppStudioError.ValidationFailedError.message([
+                getLocalizedString(
+                  "error.appstudio.localizationFile.validationFailed",
+                  filePath,
+                  validationRes.join(EOL)
+                ),
+              ]),
+              HelpLinks.WhyNeedProvision
+            )
+          );
+        }
+      } catch (e: any) {
+        return err(
+          AppStudioResultFactory.UserError(
+            AppStudioError.ValidationFailedError.name,
+            AppStudioError.ValidationFailedError.message([
+              getLocalizedString(
+                "error.appstudio.localizationFile.validationException",
+                filePath,
+                e.message
+              ),
+            ]),
+            HelpLinks.WhyNeedProvision
+          )
+        );
+      }
+    }
+    return ok(undefined);
+  }
 }