Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add schema validation for localization files #12537

Merged
merged 7 commits into from
Oct 23, 2024
Merged

feat: add schema validation for localization files #12537

merged 7 commits into from
Oct 23, 2024

Conversation

anchenyi
Copy link
Contributor

@anchenyi anchenyi commented Oct 17, 2024 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.82609% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.93%. Comparing base (ef1e054) to head (a73deb5).
Report is 107 commits behind head on dev.

Files with missing lines Patch % Lines
.../fx-core/src/component/driver/teamsApp/validate.ts 97.82% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #12537      +/-   ##
==========================================
+ Coverage   89.66%   89.93%   +0.26%     
==========================================
  Files         583      571      -12     
  Lines       34668    33761     -907     
  Branches     6768     6696      -72     
==========================================
- Hits        31085    30362     -723     
+ Misses       1588     1495      -93     
+ Partials     1995     1904      -91
Files with missing lines Coverage Δ
.../fx-core/src/component/driver/teamsApp/validate.ts 91.42% <97.82%> (+5.16%) ⬆️

... and 52 files with indirect coverage changes

@anchenyi anchenyi marked this pull request as ready for review October 21, 2024 04:00
MuyangAmigo
MuyangAmigo approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@MuyangAmigo MuyangAmigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anchenyi anchenyi merged commit 0b83296 into dev Oct 23, 2024
23 checks passed
@anchenyi anchenyi deleted the anchenyi/localization_schema branch October 23, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayzhang jayzhang jayzhang approved these changes

@MuyangAmigo MuyangAmigo MuyangAmigo approved these changes

@supkasar supkasar supkasar approved these changes

@nliu-ms nliu-ms Awaiting requested review from nliu-ms nliu-ms is a code owner

@yuqizhou77 yuqizhou77 Awaiting requested review from yuqizhou77 yuqizhou77 is a code owner

@timngmsft timngmsft Awaiting requested review from timngmsft timngmsft is a code owner

@sffamily sffamily Awaiting requested review from sffamily sffamily is a code owner

@therealjohn therealjohn Awaiting requested review from therealjohn therealjohn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anchenyi @jayzhang @MuyangAmigo @supkasar