Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The microsoft-office-addin-debugger is only required for legacy Edge, and shouldn't be needed for most scenarios. So I don't know that we want to recommend it here.
@millerds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is actually the Office Add-ins Development Kit. We leverage the old debugger's id so that we don't need to go through a whole review process. You can check it by click the link in PR description. @akrantz @AlexJerabek
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe you should be doing that. Not only is it confusing but it has the potential to bring in the old extension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand it, the Dev Kit is another tool for creating add-in projects. What is the reason for recommending it in templates that are used by other add-in creation tools?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We release the Dev Kit as a new version of the old debugger. If they click the pop-up install button of recommendation extension, they would install the latest version which is the Dev Kit. Therefore, there is no chance for developers to install an old version of VSC extension unless this is what they intend to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the ID "msoffice.microsoft-office-add-in-debugger" for the Dev Kit change, or is this permanently the old name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Dev Kit is beyond project creation and can help developers explore more on platform capabilities. For example, they can explore samples or check the useful links in the side panel when they complete trying the first project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Id will not change, still "microsoft-office-add-in-debugger".