-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD: add Dev Kit to recommended extension #268
Conversation
Must have approval from @AlexJerabek before merging. |
@@ -6,7 +6,8 @@ | |||
"recommendations": [ | |||
"ms-edgedevtools.vscode-edge-devtools", | |||
"dbaeumer.vscode-eslint", | |||
"esbenp.prettier-vscode" | |||
"esbenp.prettier-vscode", | |||
"msoffice.microsoft-office-add-in-debugger" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The microsoft-office-addin-debugger is only required for legacy Edge, and shouldn't be needed for most scenarios. So I don't know that we want to recommend it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is actually the Office Add-ins Development Kit. We leverage the old debugger's id so that we don't need to go through a whole review process. You can check it by click the link in PR description. @akrantz @AlexJerabek
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe you should be doing that. Not only is it confusing but it has the potential to bring in the old extension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is actually the Office Add-ins Development Kit. We leverage the old debugger's id so that we don't need to go through a whole review process. You can check it by click the link in PR description. @akrantz @AlexJerabek
As I understand it, the Dev Kit is another tool for creating add-in projects. What is the reason for recommending it in templates that are used by other add-in creation tools?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe you should be doing that. Not only is it confusing but it has the potential to bring in the old extension.
We release the Dev Kit as a new version of the old debugger. If they click the pop-up install button of recommendation extension, they would install the latest version which is the Dev Kit. Therefore, there is no chance for developers to install an old version of VSC extension unless this is what they intend to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the ID "msoffice.microsoft-office-add-in-debugger" for the Dev Kit change, or is this permanently the old name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Dev Kit is beyond project creation and can help developers explore more on platform capabilities. For example, they can explore samples or check the useful links in the side panel when they complete trying the first project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Id will not change, still "microsoft-office-add-in-debugger".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm inclined to approve, but do we want this to be pushed to all our developers before the tool reaches GA?
I think we can add the recommendation when the extension reaches GA for the following reasons.
|
/azurepipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azurepipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Thank you for your pull request! Please provide the following information.
Change Description:
Add https://marketplace.visualstudio.com/items?itemName=msoffice.microsoft-office-add-in-debugger to extension recommendation list of templates since it's officially released.
Do these changes impact any npm scripts commands (in package.json)? (e.g., running 'npm run start')
No
Do these changes impact VS Code debugging options (launch.json)?
No
Do these changes impact template output? (e.g., add/remove file, update file location, update file contents)
No
Do these changes impact documentation? (e.g., a tutorial on https://docs.microsoft.com/en-us/office/dev/add-ins/overview/office-add-ins)
No
If you answered yes to any of these please do the following:
> Include 'Rick-Kirkham' in the review
> Make sure the README file is correct
Validation/testing performed: