Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Arbitrum legacy transactions and receipts #114

Merged
merged 26 commits into from
Jul 23, 2022
Merged

support Arbitrum legacy transactions and receipts #114

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
c9224c4
arb-legacy transaction update
tsahee May 26, 2022
7c0e2ab
add genesisBlockNumber to arb chain params
tsahee May 31, 2022
212c8b1
move ClipToPostNitroGenesis to blockchain & use params
rachel-bousfield Jun 1, 2022
d7770e3
Merge commit '7c0e2ab4ccc68ebd4d29ec23dd1964b171d94c22' into rely-on-…
rachel-bousfield Jun 1, 2022
7590a32
ClipToPostNitro API fix
tsahee Jun 1, 2022
2f4ff02
expand arbitrum legacy Tx type
tsahee Jun 1, 2022
2e8dfcd
remove cruft
tsahee Jun 1, 2022
d9de7d7
arbitrumSigner support for arblegacyTx
tsahee Jun 9, 2022
65bd96f
support rinkeby devtest chain
tsahee Jun 12, 2022
bdf71b3
arbitrum legacy is not London
tsahee Jun 13, 2022
9c0f658
arblegacy type receipt
tsahee Jun 16, 2022
e290afa
Merge remote-tracking branch 'origin/master' into HEAD
tsahee Jun 16, 2022
0dccfa2
contractaddress for failed arblegacy receipt
tsahee Jun 16, 2022
f33e401
arbLegacyReceipt: store contractaddress
tsahee Jun 16, 2022
ea8850d
json enc/dec for ArbLegacyTx
tsahee Jun 16, 2022
c347db0
Merge remote-tracking branch 'origin/master' into arbitrum_legacy
tsahee Jun 28, 2022
038d4d9
Merge remote-tracking branch 'origin/master' into arbitrum_legacy
tsahee Jun 28, 2022
9276314
only add block fields for nitro
tsahee Jul 6, 2022
ddb137f
Merge branch 'master' into arbitrum_legacy
PlasmaPower Jul 13, 2022
43f50e2
Don't attempt to commit empty state roots
PlasmaPower Jul 13, 2022
eb90573
Merge remote-tracking branch 'origin/master' into arbitrum_legacy
tsahee Jul 19, 2022
064bca8
Merge remote-tracking branch 'origin/arbitrum_legacy' into arbitrum_l…
tsahee Jul 19, 2022
a7efb43
Return status in RPC instead of a 1-byte root for legacy receipts
PlasmaPower Jul 21, 2022
8ec3b10
Merge pull request #131 from OffchainLabs/legacy-receipt-status
tsahee Jul 22, 2022
ba0218b
fix rinkeby testnet params
tsahee Jul 23, 2022
2140a84
fix rinkeby conf
tsahee Jul 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ClipToPostNitro API fix
  • Loading branch information
@tsahee
tsahee committed Jun 1, 2022
commit 7590a32be5466e0ef14a91c5f175030a76c94b7a
2 changes: 1 addition & 1 deletion arbitrum/apibackend.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ func (a *APIBackend) FeeHistory(
}

nitroGenesis := rpc.BlockNumber(a.ChainConfig().ArbitrumChainParams.GenesisBlockNum)
newestBlock, latestBlock := a.blockChain().ClipToPostNitroGenesis(a, newestBlock)
newestBlock, latestBlock := a.blockChain().ClipToPostNitroGenesis(newestBlock)

maxFeeHistory := int(a.b.config.FeeHistoryMaxBlockCount)
if blocks > maxFeeHistory {
Expand Down
4 changes: 2 additions & 2 deletions core/blockchain_arbitrum.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ type GetsCurrentBlock interface {
CurrentBlock() *types.Block
}

func (bc *BlockChain) ClipToPostNitroGenesis(getter GetsCurrentBlock, blockNum rpc.BlockNumber) (rpc.BlockNumber, rpc.BlockNumber) {
currentBlock := rpc.BlockNumber(getter.CurrentBlock().NumberU64())
func (bc *BlockChain) ClipToPostNitroGenesis(blockNum rpc.BlockNumber) (rpc.BlockNumber, rpc.BlockNumber) {
currentBlock := rpc.BlockNumber(bc.CurrentBlock().NumberU64())
nitroGenesis := rpc.BlockNumber(bc.Config().ArbitrumChainParams.GenesisBlockNum)
if blockNum == rpc.LatestBlockNumber || blockNum == rpc.PendingBlockNumber {
blockNum = currentBlock
Expand Down