support Arbitrum legacy transactions and receipts #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chain-params-for-genesis
tsahee
commented
Jun 16, 2022
| R: (*big.Int)(dec.R), | ||
| S: (*big.Int)(dec.S), | ||
| LegacyTx: itx, | ||
| HashOverride: dec.Hash, |
There was a problem hiding this comment.
should also initialize:
EffectiveGasPrice uint64
L1BlockNumber uint64
Return status in RPC instead of a 1-byte root for legacy receipts
PlasmaPower
reviewed
Jul 23, 2022
PlasmaPower
approved these changes
Jul 23, 2022
| DataAvailabilityCommittee: false, | ||
| InitialArbOSVersion: 3, | ||
| // Not used - has init data | ||
| InitialChainOwner: common.Address{}, |
There was a problem hiding this comment.
Looking over the code again, I'm not sure we migrate chain owners, so this might be needed. I'd like to get this PR merged though, so I'll just make a follow-up PR to correct the comment.
Tristan-Wilson
pushed a commit
that referenced
this pull request
May 22, 2023
Update engine capabilities set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.