Compiling Octomap under Windows 7 VC++2008, CMake warning (Qt4)

[tmdiv]

Whilie generating Visual Studio *.sln CMake 2.8.10.1 shows warning. The produced *.sln has improper lib dependencies. The same situation appears with octomap 1.6.1, 1.6.0. Is this a bug or CMake (gui) problem?

CMAKE WARNING
Make Warning (dev) at octovis/CMakeLists_src.txt:96 (add_executable):
  Policy CMP0008 is not set: Libraries linked by full-path must have a valid
  library file name.  Run "cmake --help-policy CMP0008" for policy details.
  Use the cmake_policy command to set the policy and suppress this warning.

  Target "octovis" links to item

    C:/octomap-1.6.1/lib/liboctomap.so

  which is a full-path but not a valid library file name.
Call Stack (most recent call first):
  octovis/CMakeLists.txt:72 (INCLUDE)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at octovis/CMakeLists_src.txt:96 (add_executable):
  Policy CMP0008 is not set: Libraries linked by full-path must have a valid
  library file name.  Run "cmake --help-policy CMP0008" for policy details.
  Use the cmake_policy command to set the policy and suppress this warning.

  Target "octovis" links to item

    C:/octomap-1.6.1/lib/liboctomath.so

  which is a full-path but not a valid library file name.
Call Stack (most recent call first):
  octovis/CMakeLists.txt:72 (INCLUDE)
This warning is for project developers.  Use -Wno-dev to suppress it.

[ahornung]

That sounds like a valid warning to me, probably due to some change in CMake behavior. The file octomap/octomap-config.cmake.in probably needs an extra case for Windows (.dll) in here:

if(APPLE)
  set(SO_EXT ".dylib")
else(APPLE)
  set(SO_EXT ".so")
endif(APPLE)

Although I wonder if there is a more portable CMake way instead...

[ahornung]

Using CMAKE_SHARED_LIBRARY_SUFFIX instead of SO_EXT (and deleting the if-else-block) should fix this

[tmdiv]

Thank you for fast help.
After this change (removed if-else and added "set(CMAKE_SHARED_LIBRARY_SUFFIX)") still there is CMake warning. The only difference is that the filename is without *.so extention.

[ahornung]

@tmdiv check the commit above, can you test if this fixes it for you? You can try the code from the "devel-cmake-suffix" branch. To debug, can you post the contents of the file lib/cmake/octomap/octomap-config.cmake?

[tmdiv]

I have tried the fix. There is no CMake warning. Still VS projects: compare_octrees, exampleEDTOctomap, exampleEDT3D, octovis can't see liboctomap.dll, but there is no problem with liboctomath now.
The content of lib/cmake/octomap/octomap-config.cmake (after this fix) is below. The dlls are in C:/mapping/octomap-1.6.1/lib/debug (release)

## removed commented text ##

 set(OCTOMAP_INCLUDE_DIRS C:/mapping/octomap-1.6.1/octomap/include)
set(OCTOMAP_LIBRARY_DIRS C:/mapping/octomap-1.6.1/lib)


# Set library names as absolute paths:
set(OCTOMAP_LIBRARIES
  C:/mapping/octomap-1.6.1/lib/liboctomap.dll
  C:/mapping/octomap-1.6.1/lib/liboctomath.dll
)