Skip to content

Conversation

@DiogoSantoss
Copy link
Contributor

Cherry picking #4169 and #4170

category: misc
ticket: none

DiogoSantoss and others added 2 commits December 12, 2025 15:29
Previously `core_fetcher_proposal_blinded` had values 0 (local) or 1 (blinded). This is problematic because the default value for the gauge is also zero so when a node starts/restarts it reports a 0 value before fetching any block which makes monitoring more complicated.

This updates the values to be 2 (local) and 1 (blinded)

category: bug
ticket: none
Fixed and improving of tracing data production.

category: refactor
ticket: none
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 69.81132% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.30%. Comparing base (d42da98) to head (e7000cf).
⚠️ Report is 1 commits behind head on main-v1.8.

Files with missing lines Patch % Lines
core/validatorapi/validatorapi.go 70.58% 10 Missing ⚠️
core/consensus/qbft/qbft.go 33.33% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           main-v1.8    #4173   +/-   ##
==========================================
  Coverage      56.30%   56.30%           
==========================================
  Files            245      245           
  Lines          31246    31288   +42     
==========================================
+ Hits           17592    17618   +26     
- Misses         11339    11354   +15     
- Partials        2315     2316    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KaloyanTanev KaloyanTanev added the merge when ready Indicates bulldozer bot may merge when all checks pass label Dec 12, 2025
@obol-bulldozer obol-bulldozer bot merged commit f02d1c7 into main-v1.8 Dec 12, 2025
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the diogo/cherry-pick-1.8.0 branch December 12, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch-release merge when ready Indicates bulldozer bot may merge when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants