*: improved tracing #4169
*: improved tracing #4169
Conversation
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4169 +/- ##
==========================================
+ Coverage 56.29% 56.35% +0.05%
==========================================
Files 245 245
Lines 31246 31288 +42
==========================================
+ Hits 17591 17632 +41
+ Misses 11337 11336 -1
- Partials 2318 2320 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| duty := core.NewAttesterDuty(uint64(opts.Slot)) | ||
| ctx, span = core.StartDutyTrace(ctx, duty, "core/validatorapi.AttestationData") | ||
|
|
||
| span.SetAttributes(attribute.Int64("committee_index", int64(opts.CommitteeIndex))) |
There was a problem hiding this comment.
This here we expect it to be always 0 if fetch_only_commidx_0 is turned on which is the majority now. It will also be made default in the upcoming months. Not sure if we need that attribute.
There was a problem hiding this comment.
It shall not hurt, especially if it is not zero, suddenly :) this way we can always confirm it is zero
pinebit
added
the
merge when ready
Fixed and improving of tracing data production. category: refactor ticket: none
Fixed and improving of tracing data production. category: refactor ticket: none
Fixed and improving of tracing data production.
category: refactor
ticket: none