Skip to content

app: skip warn for unknown git hash #4057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
obol-bulldozer merged 1 commit into from
Oct 28, 2025
Merged

app: skip warn for unknown git hash #4057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/peerinfo/peerinfo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,8 @@ func (p *PeerInfo) sendOnce(ctx context.Context, now time.Time) {
p.nicknamesMu.Unlock()

// Validator git hash with regex.
if !gitHashMatch.MatchString(resp.GetGitHash()) {
log.Warn(ctx, "Invalid peer git hash", nil, z.Str("peer", name))
if !gitHashMatch.MatchString(resp.GetGitHash()) && resp.GetGitHash() != version.Unknown {
log.Warn(ctx, "Invalid peer git hash", nil, z.Str("peer", name), z.Str("peer_git_hash", resp.GetGitHash()))
return
}

Expand Down
6 changes: 5 additions & 1 deletion app/version/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ var (
vcsTime = ""
)

const (
Unknown = "unknown"
)

// Supported returns the supported minor versions in order of precedence.
func Supported() []SemVer {
return []SemVer{
Expand All @@ -49,7 +53,7 @@ func GitCommit() (hash string, timestamp string) {
return vcsRevision, vcsTime
}

hash, timestamp = "unknown", "unknown"
hash, timestamp = Unknown, Unknown
hashLen := 7

info, ok := debug.ReadBuildInfo()
Expand Down
Loading